Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CGO flags to supress warnings and fix build failures #364

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

gkeesh7
Copy link
Collaborator

@gkeesh7 gkeesh7 commented Sep 23, 2024

The build and test pipeline was failing due to one of the libararies which uses CGO bindings with the warning

sqlite3-binding.c:129019:10: warning: function may return address of local variable [-Wreturn-local-addr]
129019 |   return pNew;
       |          ^~~~
sqlite3-binding.c:128979:10: note: declared here
128979 |   Select standin; 

Failed build linked :- here

This change runs the builds on push and pull request and ignores the warnings by passing an ENV variable.

@CLAassistant
Copy link

CLAassistant commented Sep 23, 2024

CLA assistant check
All committers have signed the CLA.

@gkeesh7 gkeesh7 self-assigned this Sep 24, 2024
@gkeesh7 gkeesh7 added the bug Something isn't working label Sep 24, 2024
Copy link
Collaborator

@Anton-Kalpakchiev Anton-Kalpakchiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning is received from the github.com/mattn/go-sqlite3 package. Is there a way we can disable the warning only for that package? If not, can you add the package name in the comments where we say we suppress warnings, so it is known where we get the warnings from?

.github/workflows/build-and-test.yaml Show resolved Hide resolved
.github/workflows/build-and-test.yaml Show resolved Hide resolved
@gkeesh7
Copy link
Collaborator Author

gkeesh7 commented Sep 24, 2024

The warning is received from the github.com/mattn/go-sqlite3 package. Is there a way we can disable the warning only for that package? If not, can you add the package name in the comments where we say we suppress warnings, so it is known where we get the warnings from?

This issue is documented here mattn/go-sqlite3#803, I am landing this change to unblock the CI/CD pipeline on every push and pull requests.

Lets file an issue to upgrade in the project the version of go-sqlite3 to address this.

@gkeesh7 gkeesh7 merged commit 7ebe432 into uber:master Sep 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants