Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the init() method to the shadow backend and SQL backend code #365

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Added the init() method to the shadow backend and SQL backend code #365

merged 4 commits into from
Sep 24, 2024

Conversation

gkeesh7
Copy link
Collaborator

@gkeesh7 gkeesh7 commented Sep 24, 2024

  • Adding the init method to the shadow backend code
  • The init method register the shadow backend mode to the factory.
  • Without the register method we will have the issue of backend not being registered and an error no backend client defined with name

@gkeesh7 gkeesh7 added the bug Something isn't working label Sep 24, 2024
@gkeesh7 gkeesh7 self-assigned this Sep 24, 2024
Anton-Kalpakchiev
Anton-Kalpakchiev reviewed Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@Anton-Kalpakchiev Anton-Kalpakchiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the same change to the SQL backend too?

@gkeesh7 gkeesh7 changed the title Added the init() method to the shadow backend code Added the init() method to the shadow backend and SQL backend code Sep 24, 2024
Anton-Kalpakchiev
Anton-Kalpakchiev approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@Anton-Kalpakchiev Anton-Kalpakchiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gkeesh7 gkeesh7 merged commit bb8e894 into uber:master Sep 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anton-Kalpakchiev Anton-Kalpakchiev Anton-Kalpakchiev approved these changes

@fergusn fergusn Awaiting requested review from fergusn

@dmonojit dmonojit Awaiting requested review from dmonojit

@radicmilos radicmilos Awaiting requested review from radicmilos

@evelynl94 evelynl94 Awaiting requested review from evelynl94

@xinlongz1 xinlongz1 Awaiting requested review from xinlongz1

Assignees

@gkeesh7 gkeesh7

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gkeesh7 @Anton-Kalpakchiev @gauravkuber