Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User ID of span annotation #362

Closed
Alienmaster opened this issue Feb 19, 2024 · 3 comments · Fixed by #370
Closed

User ID of span annotation #362

Alienmaster opened this issue Feb 19, 2024 · 3 comments · Fixed by #370
Assignees
Labels
backend This issue is related to the backend bug Something isn't working

Comments

@Alienmaster
Copy link
Member

When creating an annotation span in an annotation document, the user ID of the annotation document is returned instead of the user ID of the creator of the annotation span. This can occur if user1 has created the annotation document and user2 adds an annotation span.

The data structure of the span annotations must be extended for this.

@Alienmaster Alienmaster added enhancement New feature or request backend This issue is related to the backend labels Feb 19, 2024
@floschne
Copy link
Member

This is a bug! It should not be possible for a user to write in an adoc of another user. There is always at max one adoc per user per sdoc.

@floschne floschne added bug Something isn't working and removed enhancement New feature or request labels Feb 22, 2024
@bigabig bigabig assigned bigabig and Alienmaster and unassigned bigabig Mar 12, 2024
@bigabig
Copy link
Member

bigabig commented Mar 12, 2024

bitte lösen mit Validate im Endpoint. z.B. validate.validate_own_object(user_id, adoc_id)

@bigabig
Copy link
Member

bigabig commented Mar 12, 2024

bitte auch für bbox annotations fixen

Alienmaster added a commit that referenced this issue Mar 14, 2024
@Alienmaster Alienmaster mentioned this issue Mar 14, 2024
@Alienmaster Alienmaster linked a pull request Mar 14, 2024 that will close this issue
Alienmaster added a commit that referenced this issue Sep 3, 2024
Alienmaster added a commit that referenced this issue Sep 3, 2024
Alienmaster added a commit that referenced this issue Sep 3, 2024
Alienmaster added a commit that referenced this issue Sep 3, 2024
Alienmaster added a commit that referenced this issue Sep 30, 2024
Alienmaster added a commit that referenced this issue Oct 2, 2024
Alienmaster added a commit that referenced this issue Oct 2, 2024
Alienmaster added a commit that referenced this issue Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend This issue is related to the backend bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants