Bugfix update_project api route #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floschne
approved these changes
Feb 14, 2024
|
Thanks for the fix! Does this happen in other places, too? |
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some digging i discovered the following problem:
When querying the database for the project the return value seems to be fine and can be interpret by the fastapi jsonable_encoder.
But when the method _get_action_state_from_orm is called before the jsonable_encode the db_obj seems to change its state.
This is not obvious for me since the method only returns the db_obj as a dict.
If now the jsonable_encoder is called it ends in a RecursionError by the jsonable_encoder.
A quickfix is to convert the db_obj to a dict and then use the jsonable_encoder like in the PR.
There seems to be a known problem in the jsonable_encoder: fastapi/fastapi#10359