do not format if test is not necessary #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: matt <m.bouchy@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1530 +/- ##
===========================================
- Coverage 94.29% 83.02% -11.28%
===========================================
Files 91 111 +20
Lines 7024 8151 +1127
===========================================
+ Hits 6623 6767 +144
- Misses 401 1384 +983 ☔ View full report in Codecov by Sentry. |
cosmicBboy
reviewed
Mar 18, 2024
pandera/backends/pandas/array.py
Outdated
| failure_cases = ( | ||
| reshape_failure_cases(check_obj[isna], ignore_na=False) | ||
| if not passed | ||
| else pd.DataFrame() |
There was a problem hiding this comment.
can we make sure that this empty dataframe contains the same column names as the output of reshape_failure_cases?
There was a problem hiding this comment.
This can actually also be None if the check passed
There was a problem hiding this comment.
I replaced with None, it's cleaner. I'm not sure the drop in code coverage is due to me, I can certainly look to add a test but not sure if it is absolutely necessary or where to start from.
cosmicBboy
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this issue