Add a generic Series type for polars #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Baldwin <baldwinj30@gmail.com>
cosmicBboy
reviewed
Apr 24, 2024
pandera/api/polars/model.py
Outdated
Comment on lines
100
to
101
| " pandera.typing.Series[TYPE] annotations are not supported for polars. " | ||
| "Use the pandera.typing.polars.Series[TYPE] annotation or the bare TYPE directly" |
There was a problem hiding this comment.
let's delete this part, now that polars backend now supports Series generic type.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1595 +/- ##
===========================================
- Coverage 94.29% 83.12% -11.17%
===========================================
Files 91 114 +23
Lines 7024 8490 +1466
===========================================
+ Hits 6623 7057 +434
- Misses 401 1433 +1032 ☔ View full report in Codecov by Sentry. |
cosmicBboy
approved these changes
Apr 26, 2024
|
thanks @baldwinj30 and congrats on your first contribution to pandera! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1594
Added a Series type alongside the LazyFrame type, and added it as an accepted annotation in the polars model.