Make hash of cacheable code the same as if it were uncached #5409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow passing in a unison executable on the command line, so the script doesn't have to be modified to use something other than stack.
This threads version information into the encoder so that when writing bytes for hashing, it will ignore the cacheability of code, and produce the same hash as before the caching change. @unison/internal bump does the same for the jit.
aryairani
approved these changes
Oct 10, 2024
|
What is being hashed? Most stuff didn't change. Only the hash of |
|
Oh okay, what about the hash of a Unison function? As in: You're saying that never was changed, even before this PR? |
|
Right, that is a partial application whose hash is based on the reference for |
pchiusano
added
the
ready-to-merge
mergify
bot
removed
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the change that throws away the cacheability information when serializing for hashing, so that it doesn't influence the hash.
Also tweaks the
interpreter-tests.shfile to accept a ucm on the command line, and falls back to using stack to find the file, which was accidentally changed in the last PR. This will avoid me accidentally changing it in the future.