Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an off-by-one error in the tag stack traversing #1701

Merged
merged 1 commit into from
Mar 7, 2018

Conversation

LemonBoy
Copy link
Contributor

@LemonBoy LemonBoy commented Mar 6, 2018

Since the whole stack array isn't completely cleared by the
initStack routine ctags would sometimes segfault after reading stale
or invalid data off the topmost item.

Writing a test is slightly complicated by the fact you have to "poison" the stack first.

Since the whole `stack' array isn't completely cleared by the
`initStack' routine ctags would sometimes segfault after reading stale
or invalid data off the topmost item.
@masatake
Copy link
Member

masatake commented Mar 6, 2018

Thank you. LGTM.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.604% when pulling 92d8be1 on LemonBoy:ocaml-stack into e5c86f7 on universal-ctags:master.

@masatake masatake self-assigned this Mar 7, 2018
@masatake masatake merged commit e777266 into universal-ctags:master Mar 7, 2018
@masatake
Copy link
Member

masatake commented Mar 7, 2018

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants