Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test input files are verified during make verify-units-inputs #1909

Commits on Oct 10, 2018

  1. Attempt to incorporate unit test input file checking to make check

    This is a work in progress.
    ahakanbaba committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    01bf87a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    68aa5e8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a5eb81e View commit details
    Browse the repository at this point in the history
  4. After fixing puppet files, fix the expected.tags files.

    We had to change some input.pp files to that they confirm to the puppet
    syntax. Due to those changes some tags have changed.
    ahakanbaba committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    ac54a3f View commit details
    Browse the repository at this point in the history
  5. Use an empty target instead of a phony target

    In th testing.mak, using a phony target will execute the target all the
    time. However for unit test input file checking, we only want to verify
    inputs that have been  modified.
    An empty target construct in Makefile is suitable for that.
    Also update the gitignore file to ignore the empty target files.
    ahakanbaba committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    46276ca View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    26a3a48 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7619745 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1652bf4 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    0553dc2 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b31ca7f View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2018

  1. First working attempt of further parametirization of verify-test-inputs.

    The makefile now uses two nested defines to fully parameterize the
    unit test input file parameterization.
    ahakanbaba committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    e339223 View commit details
    Browse the repository at this point in the history
  2. Minor improvements to the makefile metaprogramming

    1) Consume the stdout of the verification command. Prints too much to
    the console. Useful information to debug will be printed via the makefile
    echo and also the std err anyways
    2) Add a clean-verify-units-input command.
    ahakanbaba committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    f7132f7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8b383e7 View commit details
    Browse the repository at this point in the history
  4. Further metaprogramming improvements.

    Set the clean dependencies.
    Get the extension parameter and use it correctly in the define block
    Install further test requirements in centos container.
    ahakanbaba committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    234540f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ba44ae3 View commit details
    Browse the repository at this point in the history
  6. Install epel release first jq later.

    jq comes from epel-release.
    ahakanbaba committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    8181d5c View commit details
    Browse the repository at this point in the history