-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions: create a tag to our repo weekly if a new change is committed since last tagging #2655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should update src/ctags.h
and configure.ac
to 5.9.0
?
(If they are updated, tests should be also updated, though...)
Do you mean updating the version strings in the files WHEN tagging? |
I think it's better to set the major and the minor numbers to the same as the tag name. |
1d5a7c7
to
457ebbb
Compare
@k-takata, thank you for reviewing. I updated this pull request. I have a question.
|
Yes, "5.9.0.0" should be okay. |
Looks okay. |
misc/git-tag-maybe.sh
Outdated
desc=$(git describe --tags --always) | ||
case "${desc}" in | ||
v*) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may not work as expected.
If once v5.9.20201007.0
was tagged and some commits were added, git describe --tags --always
would return v5.9.20201007.0-N-gHHHHHHH
. (N
is a number of commits from the last tag, HHHHHHH
is the commit ID.)
If --exact-match
option is specified, git describe
will fail if the current commit is not tagged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I tried --exact-match but it seems to me that the optoin doesn't work expectedly:
$ git describe --tags --always
9ce35430
$ git tag x
$ git describe --exact-match
fatal: no tag exactly matches '9ce35430b0866d055fb18090d85bd00c1dea43d0'
$ echo $?
128
$ git describe --tags --always
x
How about pattern
v*.0)
instead of v*
?
Too stingy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about git describe --tags --exact-match
?
I decide to use |
The change of prefix must be written in a new blog entry. |
Codecov Report
@@ Coverage Diff @@
## master #2655 +/- ##
=======================================
Coverage 86.90% 86.90%
=======================================
Files 183 183
Lines 39016 39018 +2
=======================================
+ Hits 33906 33908 +2
Misses 5110 5110
Continue to review full report at Codecov.
|
…in32 related files) Updated to 5.9.0.
…mmitted since last tagging Partially close universal-ctags#1038. The tagging format is p5.9.YYYYMMDD.0. @k-takata helped me utilize git describe/tag.
50914c4
to
e9baeff
Compare
Simplified the commits. |
Let's see what happens in this Sunday. |
5.9.0 are hard-coded in many places. I must reduce them. |
Partially close #1038.
The tagging format is v5.9.YYYYMMDD.0.The tagging format is p5.9.YYYYMMDD.0.