Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clojure: Fix skipMetadata not called for functions #2728

Merged
merged 3 commits into from
Nov 25, 2020

Conversation

Cnly
Copy link
Contributor

@Cnly Cnly commented Nov 25, 2020

Functions can also have metadata, but skipMetadata is not called for them. That causes functions like

(defn ^:private test-fn [])

to be parsed as ^:private instead of test-fn. This PR fixes the problem.

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #2728 (44a6a90) into master (42f590c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2728   +/-   ##
=======================================
  Coverage   86.84%   86.84%           
=======================================
  Files         189      189           
  Lines       40253    40254    +1     
=======================================
+ Hits        34958    34959    +1     
  Misses       5295     5295           
Impacted Files Coverage Δ
parsers/clojure.c 92.20% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42f590c...44a6a90. Read the comment docs.

@coveralls
Copy link

coveralls commented Nov 25, 2020

Coverage Status

Coverage increased (+0.0003%) to 86.935% when pulling 44a6a90 on Cnly:master into 42f590c on universal-ctags:master.

@masatake
Copy link
Member

Thank you. Could you consider to add a unit test case?

https://docs.ctags.io/en/latest/units.html#how-to-write-a-test-case explains the way to add a test case.

@Cnly
Copy link
Contributor Author

Cnly commented Nov 25, 2020

@masatake Sure, should be done now.

@masatake masatake merged commit c18ddfa into universal-ctags:master Nov 25, 2020
@masatake
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants