-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
c-based: fix to handle edge case #3796
c-based: fix to handle edge case #3796
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3796 +/- ##
==========================================
- Coverage 85.07% 85.06% -0.01%
==========================================
Files 226 226
Lines 53851 53857 +6
==========================================
+ Hits 45814 45816 +2
- Misses 8037 8041 +4
☔ View full report in Codecov by Sentry. |
Thank you. |
@masatake I can tackle this issue and try to finish it. Clearly, anywhere that calls |
fce288e
to
884ef4e
Compare
I simplified my original changes, because I realized that |
Failed checks are system issues, not code. |
Github Actions may fail for network issues, If you encounter this situation next time, just rerun it. It usually would become green after rerunning. |
64d6b67
to
7227383
Compare
@masatake Here is my proposal for fixing the issue. I created I only changed the minimal number of calls so far, to minimize the size of the commit and make it easier to review. |
Give me some time. |
7227383
to
5e9053d
Compare
I merge #3804. Could you rebase this?
At this time, could you update only vStringPut in c-based.c? For fixing #3771, I have been thinking about the way of handling EOF. I have been finding my mistakes in cpreprocess.c because of my limited understanding of the file. |
5e9053d
to
f3a2e44
Compare
Thank you. |
Close universal-ctags#3771. Did the same as universal-ctags#3796. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
where "character" returned is a symbol (> 0xff)