fix: augment FetchError type to include IFetchError

[johannschopplich]

🔗 Linked issue

#278

❓ Type of change

• 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• 🧹 Chore (updates to the build process or auxiliary tools and libraries)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

With the latest ofetch version, the FetchError does implement the IFetchError interface, but TS won't provide the types. Thus, only message, stack etc. properties are available.

Since the FetchError will be initiated by createFetchError, we can add the properties from the interface directly in the class definition, without the need of setting them in the constructor. With these changes, TypeScript understands.

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

[pi0]

Thanks for this PR dear @johannschopplich but splitting the types out of the class was intentional. (sadly) esbuild adds them as public accessors which makes them (wrongly) visible on stack traces while they should be getters only.. I am thinking if possible to sole type issue somehow differently while keeping runtime minimal.

[johannschopplich]

Oh, I see! I wasn't aware of that issue. Maybe there's another way of merging the types then. 🤔

[johannschopplich]

Edit: I have updated this PR to use a type-only approach: We can augment FetchError type to include all IFetchError properties.

// Augment `FetchError` type to include `IFetchError` properties
export interface FetchError<T = any> extends IFetchError<T> {}

[pi0]

💯