Migrate from 'Travis CI' to 'GitHub Actions' (...) #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
=========================================
Coverage ? 99.47%
=========================================
Files ? 4
Lines ? 191
Branches ? 0
=========================================
Hits ? 190
Misses ? 1
Partials ? 0
Continue to review full report at Codecov.
|
urda
force-pushed
the
develop
branch
6 times, most recently
from
860a04e
to
b8d9863
Compare
Made corrections for pylint upgrade: pylint --rcfile=./.pylintrc --reports=y --output-format=text nistbeacon ************* Module nistbeacon.nistbeacon nistbeacon/nistbeacon.py:23:0: R0205: Class 'NistBeacon' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) nistbeacon/nistbeacon.py:69:12: R1705: Unnecessary "else" after "return" (no-else-return) nistbeacon/nistbeacon.py:80:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements) nistbeacon/nistbeacon.py:160:8: R1705: Unnecessary "else" after "return" (no-else-return) ************* Module nistbeacon.nistbeaconvalue nistbeacon/nistbeaconvalue.py:26:0: R0205: Class 'NistBeaconValue' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) ************* Module nistbeacon.nistbeaconcrypto nistbeacon/nistbeaconcrypto.py:26:0: R0205: Class 'NistBeaconCrypto' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance) nistbeacon/nistbeaconcrypto.py:186:21: R1719: The if expression can be replaced with 'test' (simplifiable-if-expression)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
codecovconfig into.github.travistoGitHub Actionsrunners.gitignorefor package building results ignoring.Makefile:docssome day as amakecommand ...README.pylint:pylinterror reports.setup.pyfor further cleanupNotes
Why not have
python3.9?PyLintwas not happy:See also: