Merge pull request #1786 from austinvazquez/optimize-itoa

Replace fmt.Sprintf's with strconv.Format's
urfave · Jun 26, 2023 · 4a9488f · 4a9488f
2 parents dafd175 + 4148aa8
commit 4a9488f
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 8 deletions.
diff --git a/flag_bool.go b/flag_bool.go
@@ -2,7 +2,6 @@ package cli
 
 import (
 	"errors"
-	"fmt"
 	"strconv"
 )
 
@@ -48,7 +47,7 @@ func (i boolValue) Create(val bool, p *bool, c BoolConfig) Value {
 
 // ToString formats the bool value
 func (i boolValue) ToString(b bool) string {
-	return fmt.Sprintf("%v", b)
+	return strconv.FormatBool(b)
 }
 
 // Below functions are to satisfy the flag.Value interface

diff --git a/flag_float.go b/flag_float.go
@@ -1,7 +1,6 @@
 package cli
 
 import (
-	"fmt"
 	"strconv"
 )
 
@@ -18,7 +17,7 @@ func (f floatValue) Create(val float64, p *float64, c NoConfig) Value {
 }
 
 func (f floatValue) ToString(b float64) string {
-	return fmt.Sprintf("%v", b)
+	return strconv.FormatFloat(b, 'g', -1, 64)
 }
 
 // Below functions are to satisfy the flag.Value interface

diff --git a/flag_int.go b/flag_int.go
@@ -1,7 +1,6 @@
 package cli
 
 import (
-	"fmt"
 	"strconv"
 )
 
@@ -29,7 +28,7 @@ func (i intValue) Create(val int64, p *int64, c IntegerConfig) Value {
 }
 
 func (i intValue) ToString(b int64) string {
-	return fmt.Sprintf("%d", b)
+	return strconv.FormatInt(b, 10)
 }
 
 // Below functions are to satisfy the flag.Value interface

diff --git a/flag_uint.go b/flag_uint.go
@@ -1,7 +1,6 @@
 package cli
 
 import (
-	"fmt"
 	"strconv"
 )
 
@@ -24,7 +23,7 @@ func (i uintValue) Create(val uint64, p *uint64, c IntegerConfig) Value {
 }
 
 func (i uintValue) ToString(b uint64) string {
-	return fmt.Sprintf("%d", b)
+	return strconv.FormatUint(b, 10)
 }
 
 // Below functions are to satisfy the flag.Value interface