Collapse Context into Command

[meatballhat]

What type of PR is this?

(REQUIRED)

• bug
• cleanup
• documentation
• feature

What this PR does / why we need it:

(REQUIRED)

Which issue(s) this PR fixes:

Closes #1587
Closes #1780

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

Release Notes

(REQUIRED)

[github-actions]

What is Frogbot?

[skelouse]

Quick thought: What if rather than passing (ctx.Context, cmd) to Action, Before, and After, pass a context.WithValue? Then for example rather than calling ctx.String("<flag>") you'd use <import>.String(ctx, "<flag>"). Although this would simply be flipping storing context within the urfave/cli's context to storing package context within context.Context and may complicate unit testing.

Also, will command be passed to flag Action? Action func(context.Context, cmd, T) error
I see: return s.BoolFlag.Action(ctx, cmd, s.Value())

[meatballhat]

Quick thought: What if rather than passing (ctx.Context, cmd) to Action, Before, and After, pass a context.WithValue? Then for example rather than calling ctx.String("<flag>") you'd use <import>.String(ctx, "<flag>"). Although this would simply be flipping storing context within the urfave/cli's context to storing package context within context.Context and may complicate unit testing.

@skelouse I'm pretty nervous about API signatures that intentionally pass values through context.Context's Value func. Is that what you meant?

[skelouse]

@skelouse I'm pretty nervous about API signatures that intentionally pass values through context.Context's Value func. Is that what you meant?

Yeah that's what I meant.

[meatballhat]

@skelouse I'm pretty nervous about API signatures that intentionally pass values through context.Context's Value func. Is that what you meant?

Yeah that's what I meant.

Yeeeeahh I'd like to avoid that if possible 😅 I feel nervous enough about using a context.Context value to track the internal relationship between a *Command and it's potential parent *Command.

[github-actions]

---

• Frogbot also supports Contextual Analysis, Infrastructure as Code Scanning and Secrets Detection. These features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

---

This comment was generated by JFrog Frogbot 🐸