Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return LangErrors from constructors #1504

Merged
merged 32 commits into from
Nov 21, 2022
Merged

Return LangErrors from constructors #1504

merged 32 commits into from
Nov 21, 2022

Commits on Nov 16, 2022

  1. Return ConstructorResult in deploy()

    @HCastano
    HCastano committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    536b500 View commit details
    Browse the repository at this point in the history

  2. Wrap return type with Result in metadata

    @HCastano
    HCastano committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    1ab55d9 View commit details
    Browse the repository at this point in the history

  3. Check that constructor's return Results in tests

    @HCastano
    HCastano committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    79dff48 View commit details
    Browse the repository at this point in the history

  4. Add test showing that Results are decoded correctly

    @HCastano
    HCastano committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    228604c View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Correctly generate metadata for constructors

    @HCastano
    HCastano committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    bb4c1a2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into hc-impl-lang-error-for-constructors

    @HCastano
    HCastano committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    15439a4 View commit details
    Browse the repository at this point in the history

  3. Fix some nitpicks from Andrew's PR

    @HCastano
    HCastano committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    27b6b97 View commit details
    Browse the repository at this point in the history

  4. Wrap dispatch return types with Ok 

    These can't return dispatch errors atm. I may want to clean up how this
is done later.
    @HCastano
    HCastano committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    eb10da6 View commit details
    Browse the repository at this point in the history

  5. Manually wrap metadata return with ConstructorResult

    @HCastano
    HCastano committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    8b1aa66 View commit details
    Browse the repository at this point in the history

  6. Fix existing constructor integration tests

    @HCastano
    HCastano committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    36556e7 View commit details
    Browse the repository at this point in the history

  7. Remove constructor related test from integration-flipper

    @HCastano
    HCastano committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    e61576e View commit details
    Browse the repository at this point in the history

  8. Fix compile tests

    @HCastano
    HCastano committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    a3e0b24 View commit details
    Browse the repository at this point in the history

  9. Add ident to dictionary

    @HCastano
    HCastano committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    fb8d293 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. Simplify code

    @athei
    athei committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    394ffca View commit details
    Browse the repository at this point in the history

  2. Driveby: Also simplify call dispatch

    @athei
    athei committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    2f026a2 View commit details
    Browse the repository at this point in the history

  3. Small fixes to type paths

    @HCastano
    HCastano committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    c501d84 View commit details
    Browse the repository at this point in the history

  4. Check that actual instantiate call fails

    @HCastano
    HCastano committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    c307516 View commit details
    Browse the repository at this point in the history

  5. Add some tests using the CreateBuilder

    @HCastano
    HCastano committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    aaebac4 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2022

  1. Clean up the create_builder tests

    @HCastano
    HCastano committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    b63ef91 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2022

  1. Merge branch 'master' into hc-impl-lang-error-for-constructors

    @HCastano
    HCastano committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    0c37262 View commit details
    Browse the repository at this point in the history

  2. Remove unused method

    @HCastano
    HCastano committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    ec6253d View commit details
    Browse the repository at this point in the history

  3. Format code for generating constructor return type

    @HCastano
    HCastano committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    d56b728 View commit details
    Browse the repository at this point in the history

  4. Add constructors-return-value to CI

    @HCastano
    HCastano committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    053f570 View commit details
    Browse the repository at this point in the history

  5. Move shared imports out of messages

    @HCastano
    HCastano committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    7305887 View commit details
    Browse the repository at this point in the history

  6. Appease Clippy

    @HCastano
    HCastano committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    0ef75f9 View commit details
    Browse the repository at this point in the history

  7. Appease Clippy

    @HCastano
    HCastano committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    4607a67 View commit details
    Browse the repository at this point in the history

  8. Try flipping order of tests

    @HCastano
    HCastano committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    f791bfb View commit details
    Browse the repository at this point in the history

  9. Change message name 

    Maybe it's a naming clash?
    @HCastano
    HCastano committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    5d0f164 View commit details
    Browse the repository at this point in the history

  10. Revert last two changes

    @HCastano
    HCastano committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    e8b4e75 View commit details
    Browse the repository at this point in the history

  11. Try moving message related test to different module

    @HCastano
    HCastano committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    cab6c98 View commit details
    Browse the repository at this point in the history

  12. Revert "Try moving message related test to different module" 

    This reverts commit cab6c98.
    @HCastano
    HCastano committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    4dc9973 View commit details
    Browse the repository at this point in the history

  13. Try different type for account ID

    @HCastano
    HCastano committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    ad1cab7 View commit details
    Browse the repository at this point in the history