Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CallBuilder and CreateBuilder error handling optional #1602

Merged
merged 11 commits into from
Jan 20, 2023
Merged

Make CallBuilder and CreateBuilder error handling optional #1602

merged 11 commits into from
Jan 20, 2023

Commits on Jan 19, 2023

  1. Make default behaviour of fire() to return "raw" return value

    @HCastano
    HCastano committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    947cf6c View commit details
    Browse the repository at this point in the history

  2. Update delegate call codepath to give option to handle EnvError

    @HCastano
    HCastano committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    5ff7fee View commit details
    Browse the repository at this point in the history

  3. Update CreateBuilder::instantiate()'s default cleaner as well

    @HCastano
    HCastano committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    503fddb View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2023

  1. Add a breaking change note in the changelog

    @HCastano
    HCastano committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    48023ca View commit details
    Browse the repository at this point in the history

  2. Fix delegator example

    @HCastano
    HCastano committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    dbf7ac4 View commit details
    Browse the repository at this point in the history

  3. Drive-by: rename fire() method to invoke() 

    This keeps this more consistent since we're wrapping a few methods with
`invoke` in the name anyways.
    @HCastano
    HCastano committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    72add05 View commit details
    Browse the repository at this point in the history

  4. Fix ERC-1155 example

    @HCastano
    HCastano committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    9819e76 View commit details
    Browse the repository at this point in the history

  5. Update Multisig example

    @HCastano
    HCastano committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    ff759b4 View commit details
    Browse the repository at this point in the history

  6. Fix ContractRef tests

    @HCastano
    HCastano committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    0d37811 View commit details
    Browse the repository at this point in the history

  7. Revert "Drive-by: rename fire() method to invoke()" 

    This reverts commit 72add05.

Decided it's best to do this in a standalone PR.
    @HCastano
    HCastano committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    155d416 View commit details
    Browse the repository at this point in the history

  8. Use instantiate instead of try_instantiate in delegator

    @ascjones
    ascjones committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    22a924d View commit details
    Browse the repository at this point in the history