Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.0.0-rc #1637

Merged
merged 10 commits into from
Feb 1, 2023
Merged

Release v4.0.0-rc #1637

merged 10 commits into from
Feb 1, 2023

Conversation

ascjones
Copy link
Collaborator

@ascjones ascjones commented Feb 1, 2023

The first release candidate is here! This is the first release which could become the final
v4.0.0. Any subsequent release candidates should only contain bug fixes: no API changes,
breaking or otherwise.

Breaking Changes

  1. We've renamed some of the generated message methods on the ContractRef struct. They
    have been changed from _checked to try_ (#1621)
  2. We have removed the Default implementation for AccountIds. This is because of
    security concerns around the use of the zero address which has a known private key in
    the sr25519 and ed25519 curves (#1255).

Added

  • E2E: expose call dry-run method ‒ #1624

Changed

  • Remove Default implementation for AccountId ‒ #1255
  • Rename _checked codegen call methods with try_#1621
  • Bump Substrate and subxt dependencies ‒ #1549

@ascjones ascjones marked this pull request as ready for review February 1, 2023 13:34
@ascjones
Copy link
Collaborator Author

ascjones commented Feb 1, 2023

Waiting for #1255 and a cargo-contract release PR (since ink_e2e depends on contract-build)

@ascjones
Copy link
Collaborator Author

ascjones commented Feb 1, 2023

@ascjones ascjones requested a review from a team as a code owner February 1, 2023 19:28
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2023

Codecov Report

Merging #1637 (9ce2bd6) into master (ce64dbe) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 9ce2bd6 differs from pull request most recent head 26d82a2. Consider uploading reports for the commit 26d82a2 to get more accurate results

@@            Coverage Diff             @@
##           master    #1637      +/-   ##
==========================================
+ Coverage   64.78%   64.80%   +0.01%     
==========================================
  Files         207      207              
  Lines        6376     6376              
==========================================
+ Hits         4131     4132       +1     
+ Misses       2245     2244       -1     
Impacted Files Coverage Δ
crates/allocator/src/bump.rs 88.23% <0.00%> (-0.85%) ⬇️
crates/ink/ir/src/ir/attrs.rs 78.26% <0.00%> (+0.28%) ⬆️
crates/ink/ir/src/ast/attr_args.rs 84.78% <0.00%> (+2.17%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ascjones ascjones merged commit 50b32f4 into master Feb 1, 2023
@ascjones ascjones deleted the v4.0.0-rc branch February 1, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants