add support for Windows filepath in fs handlers #1108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikdubbelboer
requested changes
Sep 20, 2021
There was a problem hiding this comment.
I don't think this is all that needs to be fixed. I also see places like
Line 983 in 4b3460a
And I see
/ being checked in a lot of places.
You also don't need the runtime.GOOS check, filepath.FromSlash takes care of that.
erikdubbelboer
requested changes
Feb 24, 2022
There was a problem hiding this comment.
Like I said before, there are many other places where / is being used or checked as well. These will all need to be changed for this to work.
I think we also need some tests to check if everything works on Windows. At the moment all FS tests are disabled on windows.
| @@ -794,6 +795,10 @@ func (h *fsHandler) handleRequest(ctx *RequestCtx) { | |||
| if !ok { | |||
| pathStr := string(path) | |||
| filePath := h.root + pathStr | |||
| switch runtime.GOOS { | |||
| case "windows": | |||
| filePath = filepath.FromSlash(filePath) | |||
There was a problem hiding this comment.
You don't need to check runtime.GOOS if you use filepath.FromSlash. It will take care of that.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not quite sure about any other way around it. Open to discuss
Fixes #1101