Refactor golangci-lint config and remove redundant nolints

[alexandear]

This PR does the following:

• add additional linter run options in GitHub lint's workflow;
• remove unused //nolint comments;
• use golangci-lint-action because it's shorted and caches data.

Options:

• --verbose for clear visibility of which set of linters is run;
• --enable=gochecknoinits enables gochecknoinits (the repo has one init() which already nolinted);
• --enable=nolintlint enables linter that reports redundant //nolint comments.

structcheck linter is deprecated and automatically disabled by golangci-lint.

[erikdubbelboer]

I'm sorry but I don't agree with removing nolint:errcheck. I know that happens a lot in tests. But I would still prefer to mark each line individually as it makes the reader aware that an error is ignored here. Without it it's hard to see if this happens or not. I also wouldn't want any new code to be added later where we forget to check there error and the linter doesn't complain.

[alexandear]

I'm sorry but I don't agree with removing nolint:errcheck. I know that happens a lot in tests. But I would still prefer to mark each line individually as it makes the reader aware that an error is ignored here. Without it it's hard to see if this happens or not. I also wouldn't want any new code to be added later where we forget to check there error and the linter doesn't complain.

@erikdubbelboer Thanks for the comment. Partially agree. Could you comment on the changed code lines? Because I don't understand what should I do. Reset only //nolint:errcheck changes?

[alexandear]

Maybe we should rewrite tc.Close() \\nolint:errcheckto _ = tc.Close()? This states explicitly we ignore the returned error.

[erikdubbelboer]

Maybe we should rewrite tc.Close() \\nolint:errcheckto _ = tc.Close()? This states explicitly we ignore the returned error.

Yes, please remove --exclude-use-default as it disables a lot more checks than just errcheck. And then just add _ = to lines that fail on errcheck.

[alexandear]

@erikdubbelboer done

[erikdubbelboer]

Thanks!