Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pprofhandler: use bytes.HasPrefix for consistency #1543

Merged
merged 1 commit into from
Apr 26, 2023
Merged

pprofhandler: use bytes.HasPrefix for consistency #1543

merged 1 commit into from
Apr 26, 2023

Conversation

alexandear
Copy link
Contributor

This PR replaces strings.HasPrefix with bytes.HasPrefix for consistency. Also, use switch instead of if-else chain.

@erikdubbelboer erikdubbelboer merged commit 00c291b into valyala:master Apr 26, 2023
@erikdubbelboer
Copy link
Collaborator

Thanks! This also causes less garbage: https://go.dev/play/p/-UQvLvZqnKT

@alexandear alexandear deleted the pprof-bytes-hasprefix branch April 26, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @erikdubbelboer