Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible race condition on request ctx done #1662 #1806

Merged
merged 5 commits into from
Jul 23, 2024
Merged

Fix possible race condition on request ctx done #1662 #1806

merged 5 commits into from
Jul 23, 2024

Conversation

byte0o
Copy link
Contributor

@byte0o byte0o commented Jul 16, 2024

Fix possible race condition on request ctx done #1662

@erikdubbelboer
Copy link
Collaborator

Almost all tests are failing.

@byte0o
Copy link
Contributor Author

byte0o commented Jul 18, 2024

Almost all tests are failing.

@erikdubbelboer This is caused by the test taking too long. I will check the reason.

@byte0o
Copy link
Contributor Author

byte0o commented Jul 18, 2024

Almost all tests are failing.

@erikdubbelboer Handled, it is a deadlock caused by using lock

erikdubbelboer
erikdubbelboer requested changes Jul 21, 2024
View reviewed changes
server.go Outdated Show resolved Hide resolved
@erikdubbelboer erikdubbelboer merged commit a7d488a into valyala:master Jul 23, 2024
19 checks passed
@erikdubbelboer
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikdubbelboer erikdubbelboer erikdubbelboer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byte0o @erikdubbelboer