Fix issues with tests interfering with each other in certain situations. #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newacorn
force-pushed
the
fasthttp_test_issue2
branch
from
f924931
to
1877e87
Compare
In some cases, the goroutines started by one test do not terminate smoothly before the next round of tests begins, causing interference between tests. Performance Impact: This results in test completion times not increasing linearly with the count value. Correctness Impact: It affects the accuracy of memory allocation test cases.
newacorn
force-pushed
the
fasthttp_test_issue2
branch
from
c2d5180
to
92d3293
Compare
newacorn
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the goroutines started by one test do not terminate smoothly before the next round of tests begins, causing interference between tests.
Performance Impact: This results in test completion times not increasing linearly with the count value.
Correctness Impact: It affects the accuracy of memory allocation test cases.
Fix partial issues of this issue.: #1839