Add configuration to not pre-read multipart form data #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikdubbelboer
requested changes
Apr 12, 2020
http.go
Outdated
| @@ -979,24 +979,26 @@ func (req *Request) MayContinue() bool { | |||
| // | |||
| // If maxBodySize > 0 and the body size exceeds maxBodySize, | |||
| // then ErrBodyTooLarge is returned. | |||
| func (req *Request) ContinueReadBody(r *bufio.Reader, maxBodySize int) error { | |||
| func (req *Request) ContinueReadBody(r *bufio.Reader, maxBodySize int, preReadMultipartForm bool) error { | |||
There was a problem hiding this comment.
The only problem I see with this pull request is that this changes the API. Anyone using this function that upgrades fasthttp will have it break their build.
I guess you could make it a ...bool so it becomes optional and backwards compatible.
There was a problem hiding this comment.
switched to ...bool
Fixed |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some servers want to treat the multipart form data as a binary blob, or at least not read/parse it until other decisions are made about the request.