Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kingston TMAs #381

Merged
merged 5 commits into from
Sep 14, 2024
Merged

Add Kingston TMAs #381

merged 5 commits into from
Sep 14, 2024

Conversation

catchingstrays
Copy link
Contributor

@catchingstrays catchingstrays commented Aug 11, 2024

Description

Add MWCR_APP, MKJP_APP, MKJS_APP

Motivation and Context

This will add TMA boundaries for Cayman Approach, Sangster Radar, and Manley Radar.

How to prove the effect of this PR?

MWCR_APP

cIqEnlc
image

MKJS_APP

mZ5KuKD
image

MKJP_APP

image
g4K7UAm

Is this a breaking change?

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My change or addition follow the formatting standard of the project.
  • I am on the list of approved contributors.

@catchingstrays
Copy link
Contributor Author

README doesn't show how to be on the list of approved contributers, it says to be determined for the emailing part.

Copy link
Collaborator

@dirtyformal dirtyformal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made inline comments in your PR, please ensure these are fixed up.

Apologies regarding the email for approval - this project is currently in an interim state. In the meantime, I have reached out to the Kingston FIR ATM to verify these changes. Please reach out to Kevaugn and let them know this is you. I have heard back from Kevaugn, and I have added you as a contributor for VATCAR.

Thanks!

Boundaries/MKJP/MKJP.json Outdated Show resolved Hide resolved
Boundaries/MKJP/MKJP.json Outdated Show resolved Hide resolved
Boundaries/MKJS/MKJS.json Outdated Show resolved Hide resolved
Boundaries/MKJS/MKJS.json Show resolved Hide resolved
Boundaries/MWCR/MWCR.json Outdated Show resolved Hide resolved
Boundaries/MWCR/MWCR.json Show resolved Hide resolved
Removed extra line, added last coordinate to be the same as the first.
Removed extra line, added last coordinate to be the same as the first.
Removed extra line, added last coordinate to be the same as the first.
@catchingstrays
Copy link
Contributor Author

Changes were made as requested.

@dirtyformal
Copy link
Collaborator

Awesome, thanks! Tested on my end, and they're looking good. Merging in now - thanks! :)

@dirtyformal dirtyformal merged commit 738206e into vatsimnetwork:main Sep 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants