Deprecate "to_timestamp" function #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuchsnj
approved these changes
Jun 30, 2023
There was a problem hiding this comment.
Overall this looks good. Just wanted to note that we also generally check the Vector regression tests for any usage of the deprecated function and replace those, but I don't see any so you should be good there.
src/compiler/compiler.rs
Outdated
| ) { | ||
| if func.ident == "to_timestamp" { | ||
| self.diagnostics.push(Box::new( | ||
| DeprecationWarning::new(format!("the `{}` function", func.ident).as_str()) |
There was a problem hiding this comment.
Not really a big deal here, but the func.indent can be inlined since it's always to_timestamp
|
Forgot to mention: please add a changelog entry for this. |
|
Should we remove this https://github.com/vectordotdev/vrl/blob/main/LICENSE-3rdparty.csv#L91? |
I had noticed this as well in #288 . I opened #290 to update the license file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #188