improve the logic for searching toolchain and python #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason the tool chain is locked down is beacuse of this issue. Using newer versions of the tool chain could cause different behavior. Though I vaguely remember a pr that fixed this a little while back? That said, this is basically a safety critical application, and while it can't follow some guidelines for such a project, locking down the compiler version prevents many issues that are hard to find and debug. It keeps things as deterministic as possible. As much as one can in C. |
|
Is there any value in this PR still if the compiler version continues to be locked down? |
|
I think we can close this one for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep the toolchain in the project folder is not a good practice. I prefer to use the system wide toolchain. And the default toolchain is a little old. Maybe we can create a wiki on where to download the latest toolchain and how to install it system wide. This commit will search the toolchain in system environment first, if it find nothing, it will search in the project or it will give an error to prompt execute make arm_sdk_install.