Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate proposal timestamps #2202

Merged
merged 3 commits into from
Sep 8, 2020
Merged

validate proposal timestamps #2202

merged 3 commits into from
Sep 8, 2020

Conversation

jeremyletang
Copy link
Member

closes #2138

@vega-ci-bot
Copy link
Collaborator

system-tests failed.

=== Test summary ===
../../grpcTesting/bvt/buildVerifyTests.py ..........................     [100%]

EVODelavega
EVODelavega approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@EVODelavega EVODelavega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremyletang jeremyletang merged commit 2b0d4d1 into develop Sep 8, 2020
@jeremyletang jeremyletang deleted the bugfix/2138-validate-proposal-timestamps branch September 8, 2020 14:18
@edd edd mentioned this pull request Sep 22, 2020
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EVODelavega EVODelavega EVODelavega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NewMarket Proposal - PROPOSAL_ERROR_UNSPECIFIED when all of 3 timestamp parameters have the same value
3 participants
@jeremyletang @vega-ci-bot @EVODelavega