Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABCI records to a path #2335

Merged
merged 3 commits into from
Oct 2, 2020
Merged

ABCI records to a path #2335

merged 3 commits into from
Oct 2, 2020

Conversation

qustavo
Copy link

@qustavo qustavo commented Oct 2, 2020

When path is specified it will use it to create a file with the format abci-record-<timestamp>

cmd/vega/node.go Outdated Show resolved Hide resolved
cmd/vega/node_pre.go Outdated Show resolved Hide resolved
cmd/vega/node.go Outdated Show resolved Hide resolved
cmd/vega/node_pre.go Outdated Show resolved Hide resolved
cmd/vega/node.go Outdated Show resolved Hide resolved
@ashleyvega ashleyvega self-requested a review October 2, 2020 12:46
Copy link
Contributor

@ashleyvega ashleyvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qustavo qustavo merged commit 3131b76 into develop Oct 2, 2020
witgaw pushed a commit that referenced this pull request Oct 6, 2020
* ABCI records to a path

* fix typo and use Join

* use different time format
@edd edd mentioned this pull request Oct 7, 2020
20 tasks
@jeremyletang jeremyletang deleted the feature/record-to-path branch March 5, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants