Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core often sends events to the broker as a batch (e.g. settlements or trades). Optional subscribers (like the ones used for the event stream) rely on an internal channel to receive these events one by one. If we send a batch of trade events to the subscriber, this means the broker will iterate over each event trying to send each trade event one by one. This may seem harmless at first, but if there's a lot of streams open, especially if some of them are behind (ie the internal channel buffer is full), this leads to a lot of overhead, increase CPU usage, and actual data/events making it out to the subscribers slower and slower. With this change, batched events from the core make their way to the subscribers as a batch, and do so quickly (as fast as a single event). How the subscribers process the individual events from that point on is less of a concern to the core/broker, and doesn't impact performance as much.