Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/vendure checkout #760

Closed

Conversation

michaelbromley
Copy link
Contributor

Cleaned up a few issues from @hangai247's work so far in #714

Namely:

  • Add missing graphql dependency to the vendure packages so that codegen works
  • Run codegen because a needed generated type was missing
  • Add customCheckout: true to the commerce.config.json file
  • Make sure to assign a Customer to the order during checkout.
  • Clean up a few errors here and there.

@vercel
Copy link

vercel bot commented May 26, 2022

@michaelbromley is attempting to deploy a commit to the Vercel Solutions Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented May 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
commerce-bigcommerce ❌ Failed (Inspect) Aug 11, 2022 at 1:06PM (UTC)
commerce-commerce ❌ Failed (Inspect) Aug 11, 2022 at 1:06PM (UTC)
commerce-commercejs ❌ Failed (Inspect) Aug 11, 2022 at 1:06PM (UTC)
commerce-kibocommerce ❌ Failed (Inspect) Aug 11, 2022 at 1:06PM (UTC)
commerce-local ✅ Ready (Inspect) Visit Preview Aug 11, 2022 at 1:06PM (UTC)
commerce-ordercloud ❌ Failed (Inspect) Aug 11, 2022 at 1:06PM (UTC)
commerce-pbt01 ❌ Failed (Inspect) Aug 11, 2022 at 1:06PM (UTC)
commerce-saleor ❌ Failed (Inspect) Aug 11, 2022 at 1:06PM (UTC)
commerce-sfcc ❌ Failed (Inspect) Aug 11, 2022 at 1:06PM (UTC)
commerce-shopify ❌ Failed (Inspect) Aug 11, 2022 at 1:06PM (UTC)
commerce-site ❌ Failed (Inspect) Aug 11, 2022 at 1:06PM (UTC)
commerce-spree ❌ Failed (Inspect) Aug 11, 2022 at 1:06PM (UTC)
commerce-swell ✅ Ready (Inspect) Visit Preview Aug 11, 2022 at 1:06PM (UTC)
commerce-vendure ❌ Failed (Inspect) Aug 11, 2022 at 1:06PM (UTC)

@briandiaz
Copy link

Hey when will this be merged?

@cond0r
Copy link
Contributor

cond0r commented Aug 11, 2022

@michaelbromley Hello, this PR contains type errors, so the preview deployment has failed.

Screen Shot 2022-08-11 at 2 28 02 PM

@PicchiKevin
Copy link

Quickly ran this, no apparent bugs. Can you please review this @lfades?

@dnk8n
Copy link

dnk8n commented Dec 22, 2022

What's the status of this? Are we able to use Vendure with Next.js Commerce?

@GamfaleanuVlad
Copy link

Heyo, is this branch usable? I would kinda need this in the near future and I don't really care if it is on the main branch or anything.

@michaelbromley
Copy link
Contributor Author

@GamfaleanuVlad as far as I know, yes. But since this branch is pretty old now, you might need to merge the latest updates from main and potentially handle any conflicts or changes. Hopefully there won't be too many.

@leerob
Copy link
Member

leerob commented Apr 18, 2023

Hey there! Thank you for your contribution. We have decided to take Next.js Commerce in a new direction and will be closing out current PRs and issues due to this change. Please see this PR for more details: #966

Happy to talk about the Vendure version of v2!

@leerob leerob closed this Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants