Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add review feature and disable it for BC stores #814

Closed
wants to merge 1 commit into from

Conversation

powerwlsl
Copy link

Currently reviews and ratings are hard-coded and we want to disable it for the BC stores. Let me know if there are more steps when adding a feature!

@vercel
Copy link

vercel bot commented Aug 10, 2022

@powerwlsl is attempting to deploy a commit to the Vercel Solutions Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Aug 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
commerce-bigcommerce ❌ Failed (Inspect) Aug 10, 2022 at 5:52PM (UTC)
commerce-commerce ❌ Failed (Inspect) Aug 10, 2022 at 5:52PM (UTC)
commerce-commercejs ❌ Failed (Inspect) Aug 10, 2022 at 5:52PM (UTC)
commerce-kibocommerce ❌ Failed (Inspect) Aug 10, 2022 at 5:52PM (UTC)
commerce-local ✅ Ready (Inspect) Visit Preview Aug 10, 2022 at 5:52PM (UTC)
commerce-ordercloud ❌ Failed (Inspect) Aug 10, 2022 at 5:52PM (UTC)
commerce-pbt01 ❌ Failed (Inspect) Aug 10, 2022 at 5:52PM (UTC)
commerce-saleor ❌ Failed (Inspect) Aug 10, 2022 at 5:52PM (UTC)
commerce-sfcc ❌ Failed (Inspect) Aug 10, 2022 at 5:52PM (UTC)
commerce-shopify ❌ Failed (Inspect) Aug 10, 2022 at 5:52PM (UTC)
commerce-site ❌ Failed (Inspect) Aug 10, 2022 at 5:52PM (UTC)
commerce-spree ❌ Failed (Inspect) Aug 10, 2022 at 5:52PM (UTC)
commerce-swell ❌ Failed (Inspect) Aug 10, 2022 at 5:52PM (UTC)
commerce-vendure ❌ Failed (Inspect) Aug 10, 2022 at 5:52PM (UTC)

@cond0r
Copy link
Contributor

cond0r commented Aug 19, 2022

@powerwlsl The site example is more to show the functionality of the commerce package & providers. So in forks, anyone can change the site how is desired; no need to enable or disable it like this. And with this feature since is not implemented in any provider, you can safely remove it completely from your fork.

@powerwlsl
Copy link
Author

Hi @cond0r! I understand what you meant and I think that would also work.
But we came up with this idea because we wanted to make a default store for BC users less confusing by removing non functioning components. But if the Vercel team doesn't like our approach, we can follow as you said.

@leerob
Copy link
Member

leerob commented Apr 18, 2023

Hey there! Thank you for your contribution. We have decided to take Next.js Commerce in a new direction and will be closing out current PRs and issues due to this change. Please see this PR for more details: #966

P.S. we would love to see a BigCommerce version of the new v2 and happy to chat more about this 🙏

@leerob leerob closed this Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants