Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(next-storybook): make rules an array in webpack config #22125

Merged
merged 7 commits into from
May 5, 2021
Merged

fix(next-storybook): make rules an array in webpack config #22125

merged 7 commits into from
May 5, 2021

Conversation

stefanprobst
Copy link
Contributor

the next-storybook plugin throws an error since version 10.0.6-canary.9, specifically since #17306:

ERR! WebpackOptionsValidationError: Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.
ERR!  - configuration.module.rules should be an array

this PR makes module.rules an array again.

also see #17306 (comment)

@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@stefanprobst stefanprobst mentioned this pull request Mar 13, 2021
Closed
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@stefanprobst
Copy link
Contributor Author

could somebody have a look at this please? thx

@leerob leerob closed this Apr 23, 2021
@leerob leerob reopened this Apr 23, 2021
@stefanprobst
Copy link
Contributor Author

@leerob i see you closed and reopened, but didn't leave a comment. anything i can clarify?

@ijjk
Copy link
Member

ijjk commented May 4, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary stefanprobst/next.js fix/storybook-webpack Change
buildDuration 14.8s 14.4s -375ms
buildDurationCached 4.7s 4.4s -263ms
nodeModulesSize 46.6 MB 46.6 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary stefanprobst/next.js fix/storybook-webpack Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.383 2.38 0
/ avg req/sec 1049.03 1050.43 +1.4
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.238 1.276 ⚠️ +0.04
/error-in-render avg req/sec 2020.19 1958.61 ⚠️ -61.58
Client Bundles (main, webpack, commons)
vercel/next.js canary stefanprobst/next.js fix/storybook-webpack Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.3 kB 19.3 kB ✓
webpack-HASH.js gzip 996 B 996 B ✓
Overall change 59.6 kB 59.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary stefanprobst/next.js fix/storybook-webpack Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary stefanprobst/next.js fix/storybook-webpack Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.04 kB 3.04 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 8.51 kB 8.51 kB ✓
Client Build Manifests
vercel/next.js canary stefanprobst/next.js fix/storybook-webpack Change
_buildManifest.js gzip 393 B 393 B ✓
Overall change 393 B 393 B ✓
Rendered Page Sizes
vercel/next.js canary stefanprobst/next.js fix/storybook-webpack Change
index.html gzip 561 B 561 B ✓
link.html gzip 570 B 570 B ✓
withRouter.html gzip 557 B 557 B ✓
Overall change 1.69 kB 1.69 kB ✓
Serverless Mode (Decrease detected ✓)
General
vercel/next.js canary stefanprobst/next.js fix/storybook-webpack Change
buildDuration 17.9s 17.6s -359ms
buildDurationCached 6.6s 6.7s ⚠️ +32ms
nodeModulesSize 46.6 MB 46.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary stefanprobst/next.js fix/storybook-webpack Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.3 kB 19.3 kB ✓
webpack-HASH.js gzip 996 B 996 B ✓
Overall change 59.6 kB 59.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary stefanprobst/next.js fix/storybook-webpack Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary stefanprobst/next.js fix/storybook-webpack Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.04 kB 3.04 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 8.51 kB 8.51 kB ✓
Client Build Manifests
vercel/next.js canary stefanprobst/next.js fix/storybook-webpack Change
_buildManifest.js gzip 393 B 393 B ✓
Overall change 393 B 393 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary stefanprobst/next.js fix/storybook-webpack Change
_error.js 1.34 MB 1.34 MB ✓
404.html 2.42 kB 2.42 kB ✓
500.html 2.41 kB 2.41 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.61 kB 1.61 kB ✓
css.html 1.79 kB 1.79 kB ✓
hooks.html 1.67 kB 1.67 kB ✓
index.js 1.34 MB 1.34 MB ✓
link.js 1.4 MB 1.4 MB ✓
routerDirect.js 1.39 MB 1.39 MB ✓
withRouter.js 1.39 MB 1.39 MB -2 B
Overall change 6.9 MB 6.9 MB -2 B
Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary stefanprobst/next.js fix/storybook-webpack Change
buildDuration 12s 12.1s ⚠️ +53ms
buildDurationCached 5.1s 4.9s -156ms
nodeModulesSize 46.6 MB 46.6 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary stefanprobst/next.js fix/storybook-webpack Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.419 2.391 -0.03
/ avg req/sec 1033.3 1045.75 +12.45
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.276 1.301 ⚠️ +0.02
/error-in-render avg req/sec 1959.85 1921.23 ⚠️ -38.62
Client Bundles (main, webpack, commons)
vercel/next.js canary stefanprobst/next.js fix/storybook-webpack Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.19 kB 7.19 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary stefanprobst/next.js fix/storybook-webpack Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary stefanprobst/next.js fix/storybook-webpack Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary stefanprobst/next.js fix/storybook-webpack Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary stefanprobst/next.js fix/storybook-webpack Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 533346f

@kodiakhq kodiakhq bot merged commit 3a2cd0e into vercel:canary May 5, 2021
@stefanprobst stefanprobst deleted the fix/storybook-webpack branch May 5, 2021 07:27
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
@stefanprobst
fix(next-storybook): make rules an array in webpack config (vercel#22125
3bb922d 
)

the `next-storybook` plugin throws an error since version `10.0.6-canary.9`, specifically since vercel#17306:

```
ERR! WebpackOptionsValidationError: Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.
ERR!  - configuration.module.rules should be an array
```

this PR makes `module.rules` an array again.

also see vercel#17306 (comment)
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leerob leerob leerob approved these changes

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

@divmain divmain Awaiting requested review from divmain

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanprobst @ijjk @leerob