Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint Plugin: Custom Font at page-level rule #24789

Merged
merged 6 commits into from
May 10, 2021
Merged

ESLint Plugin: Custom Font at page-level rule #24789

merged 6 commits into from
May 10, 2021

Conversation

housseindjirdeh
Copy link
Collaborator

Adds a lint rule warning to the Next.js ESLint plugin if a custom Google Font is added at page-level instead of with a custom document (.document.js)

Note: This will be generalized to include more font providers in the near future.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

timneutkens
timneutkens previously approved these changes May 7, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented May 10, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary housseindjirdeh/next.js custom-font-per-page-eslint-rule Change
buildDuration 14.4s 15.1s ⚠️ +686ms
buildDurationCached 5s 4.6s -393ms
nodeModulesSize 46.5 MB 46.5 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary housseindjirdeh/next.js custom-font-per-page-eslint-rule Change
/ failed reqs 0 0
/ total time (seconds) 2.553 2.594 ⚠️ +0.04
/ avg req/sec 979.08 963.65 ⚠️ -15.43
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.514 1.542 ⚠️ +0.03
/error-in-render avg req/sec 1651.73 1621.59 ⚠️ -30.14
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js custom-font-per-page-eslint-rule Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 19.3 kB 19.3 kB
webpack-HASH.js gzip 994 B 994 B
Overall change 59.6 kB 59.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js custom-font-per-page-eslint-rule Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary housseindjirdeh/next.js custom-font-per-page-eslint-rule Change
_app-HASH.js gzip 1.02 kB 1.02 kB
_error-HASH.js gzip 3.05 kB 3.05 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 1.65 kB 1.65 kB
routerDirect..HASH.js gzip 331 B 331 B
withRouter-HASH.js gzip 329 B 329 B
99a142a5cfae..804.css gzip 125 B 125 B
Overall change 8.52 kB 8.52 kB
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js custom-font-per-page-eslint-rule Change
_buildManifest.js gzip 394 B 394 B
Overall change 394 B 394 B
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js custom-font-per-page-eslint-rule Change
index.html gzip 561 B 561 B
link.html gzip 569 B 569 B
withRouter.html gzip 557 B 557 B
Overall change 1.69 kB 1.69 kB

Serverless Mode (Decrease detected ✓)
General
vercel/next.js canary housseindjirdeh/next.js custom-font-per-page-eslint-rule Change
buildDuration 18.3s 18.3s -9ms
buildDurationCached 6.9s 6.9s ⚠️ +50ms
nodeModulesSize 46.5 MB 46.5 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js custom-font-per-page-eslint-rule Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 19.3 kB 19.3 kB
webpack-HASH.js gzip 994 B 994 B
Overall change 59.6 kB 59.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js custom-font-per-page-eslint-rule Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary housseindjirdeh/next.js custom-font-per-page-eslint-rule Change
_app-HASH.js gzip 1.02 kB 1.02 kB
_error-HASH.js gzip 3.05 kB 3.05 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 1.65 kB 1.65 kB
routerDirect..HASH.js gzip 331 B 331 B
withRouter-HASH.js gzip 329 B 329 B
99a142a5cfae..804.css gzip 125 B 125 B
Overall change 8.52 kB 8.52 kB
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js custom-font-per-page-eslint-rule Change
_buildManifest.js gzip 394 B 394 B
Overall change 394 B 394 B
Serverless bundles Overall decrease ✓
vercel/next.js canary housseindjirdeh/next.js custom-font-per-page-eslint-rule Change
_error.js 1.34 MB 1.34 MB
404.html 2.42 kB 2.42 kB
500.html 2.41 kB 2.41 kB
amp.amp.html 10.8 kB 10.8 kB
amp.html 1.61 kB 1.61 kB
css.html 1.79 kB 1.79 kB
hooks.html 1.67 kB 1.67 kB
index.js 1.34 MB 1.34 MB -2 B
link.js 1.4 MB 1.4 MB -2 B
routerDirect.js 1.39 MB 1.39 MB ⚠️ +2 B
withRouter.js 1.39 MB 1.39 MB
Overall change 6.9 MB 6.9 MB -2 B

Webpack 4 Mode (Increase detected ⚠️)
General
vercel/next.js canary housseindjirdeh/next.js custom-font-per-page-eslint-rule Change
buildDuration 12.9s 13.4s ⚠️ +568ms
buildDurationCached 5.6s 5.6s -30ms
nodeModulesSize 46.5 MB 46.5 MB
Page Load Tests Overall increase ✓
vercel/next.js canary housseindjirdeh/next.js custom-font-per-page-eslint-rule Change
/ failed reqs 0 0
/ total time (seconds) 2.687 2.704 ⚠️ +0.02
/ avg req/sec 930.25 924.47 ⚠️ -5.78
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.666 1.624 -0.04
/error-in-render avg req/sec 1500.7 1539.22 +38.52
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js custom-font-per-page-eslint-rule Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 7.19 kB 7.19 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 60.2 kB 60.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js custom-font-per-page-eslint-rule Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary housseindjirdeh/next.js custom-font-per-page-eslint-rule Change
_app-HASH.js gzip 1.28 kB 1.28 kB
_error-HASH.js gzip 3.72 kB 3.72 kB
amp-HASH.js gzip 536 B 536 B
css-HASH.js gzip 339 B 339 B
hooks-HASH.js gzip 887 B 887 B
index-HASH.js gzip 227 B 227 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 303 B 303 B
withRouter-HASH.js gzip 302 B 302 B
21c68fa65a48..217.css gzip 125 B 125 B
Overall change 9.37 kB 9.37 kB
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js custom-font-per-page-eslint-rule Change
_buildManifest.js gzip 420 B 420 B
Overall change 420 B 420 B
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js custom-font-per-page-eslint-rule Change
index.html gzip 614 B 614 B
link.html gzip 619 B 619 B
withRouter.html gzip 607 B 607 B
Overall change 1.84 kB 1.84 kB
Commit: 0a11ace

@kodiakhq kodiakhq bot merged commit 4407220 into vercel:canary May 10, 2021
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
Adds a lint rule warning to the Next.js ESLint plugin if a custom Google Font is added at page-level instead of with a custom document (`.document.js`)

_Note: This will be generalized to include more font providers in the near future._
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants