Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version note for has property #24836

Merged
merged 5 commits into from
May 6, 2021
Merged

Conversation

tubbo
Copy link
Contributor

@tubbo tubbo commented May 5, 2021

The guides for next.config.js never specify that the has: { } syntax is only available for v10.1, and not for v10.0. Add a note that indicates these features are only available in the latest version.

Documentation / Examples

  • Make sure the linting passes

@leerob
Copy link
Member

leerob commented May 5, 2021

There's merge conflicts because the docs have been updated to remove the experimental note: https://github.com/vercel/next.js/blob/canary/docs/api-reference/next.config.js/rewrites.md#header-cookie-and-query-matching

Instead, let's add this to denote the version it was added under that section

<details>
  <summary><b>Version History</b></summary>

| Version   | Changes                   |
| --------- | ------------------- |
| `v10.0.2` | `has` added.           |

</details>

The guides for `next.config.js` never specify that the `has: { }` syntax
is only available for v10.1, and not for v10.0. Add a note that
indicates these features are only available in the latest version.
@tubbo
Copy link
Contributor Author

tubbo commented May 5, 2021

@leerob done!

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks.

@timneutkens timneutkens changed the title docs: fix misleading documentation on redirects Add version note for has property May 6, 2021
@kodiakhq kodiakhq bot merged commit 73e1fb4 into vercel:canary May 6, 2021
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
The guides for `next.config.js` never specify that the `has: { }` syntax is only available for v10.1, and not for v10.0. Add a note that indicates these features are only available in the latest version.

## Documentation / Examples

- [x] Make sure the linting passes
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants