Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint Plugin: Disallow <title> in Head from next/document #24868

Merged
merged 3 commits into from
May 7, 2021
Merged

ESLint Plugin: Disallow <title> in Head from next/document #24868

merged 3 commits into from
May 7, 2021

Conversation

housseindjirdeh
Copy link
Collaborator

Adds lint rule warning to the Next.js ESLint plugin to disallow <title> in Head imported from next/document.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented May 7, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary housseindjirdeh/next.js title-in-document-head-eslint-rule Change
buildDuration 14.3s 14.4s ⚠️ +106ms
buildDurationCached 4.8s 4.5s -286ms
nodeModulesSize 46.6 MB 46.6 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary housseindjirdeh/next.js title-in-document-head-eslint-rule Change
/ failed reqs 0 0
/ total time (seconds) 2.37 2.38 ⚠️ +0.01
/ avg req/sec 1054.73 1050.42 ⚠️ -4.31
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.261 1.289 ⚠️ +0.03
/error-in-render avg req/sec 1982.48 1939.12 ⚠️ -43.36
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js title-in-document-head-eslint-rule Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 19.3 kB 19.3 kB
webpack-HASH.js gzip 996 B 996 B
Overall change 59.6 kB 59.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js title-in-document-head-eslint-rule Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary housseindjirdeh/next.js title-in-document-head-eslint-rule Change
_app-HASH.js gzip 1.02 kB 1.02 kB
_error-HASH.js gzip 3.05 kB 3.05 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 1.65 kB 1.65 kB
routerDirect..HASH.js gzip 331 B 331 B
withRouter-HASH.js gzip 329 B 329 B
99a142a5cfae..804.css gzip 125 B 125 B
Overall change 8.52 kB 8.52 kB
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js title-in-document-head-eslint-rule Change
_buildManifest.js gzip 394 B 394 B
Overall change 394 B 394 B
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js title-in-document-head-eslint-rule Change
index.html gzip 560 B 560 B
link.html gzip 569 B 569 B
withRouter.html gzip 557 B 557 B
Overall change 1.69 kB 1.69 kB

Serverless Mode
General
vercel/next.js canary housseindjirdeh/next.js title-in-document-head-eslint-rule Change
buildDuration 17.7s 17.7s ⚠️ +5ms
buildDurationCached 6.6s 6.7s ⚠️ +101ms
nodeModulesSize 46.6 MB 46.6 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js title-in-document-head-eslint-rule Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 19.3 kB 19.3 kB
webpack-HASH.js gzip 996 B 996 B
Overall change 59.6 kB 59.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js title-in-document-head-eslint-rule Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary housseindjirdeh/next.js title-in-document-head-eslint-rule Change
_app-HASH.js gzip 1.02 kB 1.02 kB
_error-HASH.js gzip 3.05 kB 3.05 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 1.65 kB 1.65 kB
routerDirect..HASH.js gzip 331 B 331 B
withRouter-HASH.js gzip 329 B 329 B
99a142a5cfae..804.css gzip 125 B 125 B
Overall change 8.52 kB 8.52 kB
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js title-in-document-head-eslint-rule Change
_buildManifest.js gzip 394 B 394 B
Overall change 394 B 394 B
Serverless bundles
vercel/next.js canary housseindjirdeh/next.js title-in-document-head-eslint-rule Change
_error.js 1.34 MB 1.34 MB
404.html 2.42 kB 2.42 kB
500.html 2.41 kB 2.41 kB
amp.amp.html 10.8 kB 10.8 kB
amp.html 1.61 kB 1.61 kB
css.html 1.79 kB 1.79 kB
hooks.html 1.67 kB 1.67 kB
index.js 1.35 MB 1.35 MB
link.js 1.4 MB 1.4 MB
routerDirect.js 1.39 MB 1.39 MB
withRouter.js 1.39 MB 1.39 MB
Overall change 6.9 MB 6.9 MB

Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary housseindjirdeh/next.js title-in-document-head-eslint-rule Change
buildDuration 12.3s 12.3s ⚠️ +18ms
buildDurationCached 5.2s 5.1s -44ms
nodeModulesSize 46.6 MB 46.6 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary housseindjirdeh/next.js title-in-document-head-eslint-rule Change
/ failed reqs 0 0
/ total time (seconds) 2.428 2.472 ⚠️ +0.04
/ avg req/sec 1029.61 1011.13 ⚠️ -18.48
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.231 1.292 ⚠️ +0.06
/error-in-render avg req/sec 2031.03 1935.1 ⚠️ -95.93
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js title-in-document-head-eslint-rule Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 7.19 kB 7.19 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 60.2 kB 60.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js title-in-document-head-eslint-rule Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary housseindjirdeh/next.js title-in-document-head-eslint-rule Change
_app-HASH.js gzip 1.28 kB 1.28 kB
_error-HASH.js gzip 3.72 kB 3.72 kB
amp-HASH.js gzip 536 B 536 B
css-HASH.js gzip 339 B 339 B
hooks-HASH.js gzip 887 B 887 B
index-HASH.js gzip 227 B 227 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 303 B 303 B
withRouter-HASH.js gzip 302 B 302 B
21c68fa65a48..217.css gzip 125 B 125 B
Overall change 9.37 kB 9.37 kB
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js title-in-document-head-eslint-rule Change
_buildManifest.js gzip 420 B 420 B
Overall change 420 B 420 B
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js title-in-document-head-eslint-rule Change
index.html gzip 613 B 613 B
link.html gzip 620 B 620 B
withRouter.html gzip 606 B 606 B
Overall change 1.84 kB 1.84 kB
Commit: 82c70a1

@kodiakhq kodiakhq bot merged commit 656c2ef into vercel:canary May 7, 2021
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
)

Adds lint rule warning to the Next.js ESLint plugin to disallow `<title>` in `Head` imported from `next/document`.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants