Make next.config.js keys optional #25204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PepijnSenders
requested review from
divmain,
ijjk,
lfades,
shuding and
timneutkens
as code owners
PepijnSenders
force-pushed
the
feature/make-nextconfig-keys-optional
branch
from
56988d3
to
2b870ad
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
timneutkens
approved these changes
May 18, 2021
ijjk
approved these changes
May 18, 2021
Stats from current PRDefault Server Mode (Increase detected
|
| vercel/next.js canary | PepijnSenders/next.js feature/make-nextconfig-keys-optional | Change | |
|---|---|---|---|
| buildDuration | 15.5s | 15.9s | |
| buildDurationCached | 4.8s | 4.6s | -113ms |
| nodeModulesSize | 46.7 MB | 46.7 MB |
Page Load Tests Overall increase ✓
| vercel/next.js canary | PepijnSenders/next.js feature/make-nextconfig-keys-optional | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.703 | 2.647 | -0.06 |
| / avg req/sec | 924.98 | 944.56 | +19.58 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.559 | 1.562 | 0 |
| /error-in-render avg req/sec | 1604 | 1600.23 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | PepijnSenders/next.js feature/make-nextconfig-keys-optional | Change | |
|---|---|---|---|
| framework-HASH.js gzip | 39.3 kB | 39.3 kB | ✓ |
| main-HASH.js gzip | 19.4 kB | 19.4 kB | ✓ |
| webpack-HASH.js gzip | 994 B | 994 B | ✓ |
| Overall change | 59.7 kB | 59.7 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | PepijnSenders/next.js feature/make-nextconfig-keys-optional | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
| Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
| vercel/next.js canary | PepijnSenders/next.js feature/make-nextconfig-keys-optional | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 1.02 kB | 1.02 kB | ✓ |
| _error-HASH.js gzip | 3.06 kB | 3.06 kB | ✓ |
| amp-HASH.js gzip | 526 B | 526 B | ✓ |
| css-HASH.js gzip | 334 B | 334 B | ✓ |
| hooks-HASH.js gzip | 890 B | 890 B | ✓ |
| index-HASH.js gzip | 262 B | 262 B | ✓ |
| link-HASH.js gzip | 1.65 kB | 1.65 kB | ✓ |
| routerDirect..HASH.js gzip | 331 B | 331 B | ✓ |
| withRouter-HASH.js gzip | 329 B | 329 B | ✓ |
| bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
| Overall change | 8.54 kB | 8.54 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | PepijnSenders/next.js feature/make-nextconfig-keys-optional | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 390 B | 390 B | ✓ |
| Overall change | 390 B | 390 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | PepijnSenders/next.js feature/make-nextconfig-keys-optional | Change | |
|---|---|---|---|
| index.html gzip | 561 B | 561 B | ✓ |
| link.html gzip | 570 B | 570 B | ✓ |
| withRouter.html gzip | 558 B | 558 B | ✓ |
| Overall change | 1.69 kB | 1.69 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
| vercel/next.js canary | PepijnSenders/next.js feature/make-nextconfig-keys-optional | Change | |
|---|---|---|---|
| buildDuration | 18.7s | 18.7s | -26ms |
| buildDurationCached | 5.8s | 5.8s | -6ms |
| nodeModulesSize | 46.7 MB | 46.7 MB |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | PepijnSenders/next.js feature/make-nextconfig-keys-optional | Change | |
|---|---|---|---|
| framework-HASH.js gzip | 39.3 kB | 39.3 kB | ✓ |
| main-HASH.js gzip | 19.4 kB | 19.4 kB | ✓ |
| webpack-HASH.js gzip | 994 B | 994 B | ✓ |
| Overall change | 59.7 kB | 59.7 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | PepijnSenders/next.js feature/make-nextconfig-keys-optional | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
| Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
| vercel/next.js canary | PepijnSenders/next.js feature/make-nextconfig-keys-optional | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 1.02 kB | 1.02 kB | ✓ |
| _error-HASH.js gzip | 3.06 kB | 3.06 kB | ✓ |
| amp-HASH.js gzip | 526 B | 526 B | ✓ |
| css-HASH.js gzip | 334 B | 334 B | ✓ |
| hooks-HASH.js gzip | 890 B | 890 B | ✓ |
| index-HASH.js gzip | 262 B | 262 B | ✓ |
| link-HASH.js gzip | 1.65 kB | 1.65 kB | ✓ |
| routerDirect..HASH.js gzip | 331 B | 331 B | ✓ |
| withRouter-HASH.js gzip | 329 B | 329 B | ✓ |
| bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
| Overall change | 8.54 kB | 8.54 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | PepijnSenders/next.js feature/make-nextconfig-keys-optional | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 390 B | 390 B | ✓ |
| Overall change | 390 B | 390 B | ✓ |
Serverless bundles
| vercel/next.js canary | PepijnSenders/next.js feature/make-nextconfig-keys-optional | Change | |
|---|---|---|---|
| _error.js | 17 kB | 17 kB | ✓ |
| 404.html | 2.42 kB | 2.42 kB | ✓ |
| 500.html | 2.41 kB | 2.41 kB | ✓ |
| amp.amp.html | 10.8 kB | 10.8 kB | ✓ |
| amp.html | 1.61 kB | 1.61 kB | ✓ |
| css.html | 1.79 kB | 1.79 kB | ✓ |
| hooks.html | 1.67 kB | 1.67 kB | ✓ |
| index.js | 17.3 kB | 17.3 kB | ✓ |
| link.js | 17.6 kB | 17.6 kB | ✓ |
| routerDirect.js | 17.5 kB | 17.5 kB | ✓ |
| withRouter.js | 17.6 kB | 17.6 kB | ✓ |
| Overall change | 108 kB | 108 kB | ✓ |
Webpack 4 Mode (Increase detected ⚠️ )
General Overall increase ⚠️
| vercel/next.js canary | PepijnSenders/next.js feature/make-nextconfig-keys-optional | Change | |
|---|---|---|---|
| buildDuration | 13.3s | 13.3s | |
| buildDurationCached | 5.6s | 5.6s | |
| nodeModulesSize | 46.7 MB | 46.7 MB |
Page Load Tests Overall increase ✓
| vercel/next.js canary | PepijnSenders/next.js feature/make-nextconfig-keys-optional | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.714 | 2.774 | |
| / avg req/sec | 921.13 | 901.22 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.582 | 1.554 | -0.03 |
| /error-in-render avg req/sec | 1580.36 | 1609.09 | +28.73 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | PepijnSenders/next.js feature/make-nextconfig-keys-optional | Change | |
|---|---|---|---|
| 677f882d2ed8..HASH.js gzip | 13.3 kB | 13.3 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-HASH.js gzip | 7.26 kB | 7.26 kB | ✓ |
| webpack-HASH.js gzip | 751 B | 751 B | ✓ |
| Overall change | 60.3 kB | 60.3 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | PepijnSenders/next.js feature/make-nextconfig-keys-optional | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
| Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
| vercel/next.js canary | PepijnSenders/next.js feature/make-nextconfig-keys-optional | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-HASH.js gzip | 3.74 kB | 3.74 kB | ✓ |
| amp-HASH.js gzip | 536 B | 536 B | ✓ |
| css-HASH.js gzip | 339 B | 339 B | ✓ |
| hooks-HASH.js gzip | 887 B | 887 B | ✓ |
| index-HASH.js gzip | 227 B | 227 B | ✓ |
| link-HASH.js gzip | 1.64 kB | 1.64 kB | ✓ |
| routerDirect..HASH.js gzip | 303 B | 303 B | ✓ |
| withRouter-HASH.js gzip | 302 B | 302 B | ✓ |
| e025d2764813..52f.css gzip | 125 B | 125 B | ✓ |
| Overall change | 9.38 kB | 9.38 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | PepijnSenders/next.js feature/make-nextconfig-keys-optional | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 420 B | 420 B | ✓ |
| Overall change | 420 B | 420 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | PepijnSenders/next.js feature/make-nextconfig-keys-optional | Change | |
|---|---|---|---|
| index.html gzip | 614 B | 614 B | ✓ |
| link.html gzip | 620 B | 620 B | ✓ |
| withRouter.html gzip | 607 B | 607 B | ✓ |
| Overall change | 1.84 kB | 1.84 kB | ✓ |
This was referenced May 19, 2021
This was referenced May 19, 2021
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Jun 1, 2021
## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Description These values should be optional and not required on the `NextConfig` type.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
fixes #numberDescription
These values should be optional and not required on the
NextConfigtype.