Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update beforeFiles rewrites to continue #25418

Merged
merged 1 commit into from
May 24, 2021
Merged

Update beforeFiles rewrites to continue #25418

merged 1 commit into from
May 24, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 24, 2021

This updates beforeFiles rewrites to continue instead of matching a public file/page immediately after a match, this allows all beforeFiles routes to be checked before matching the filesystem.

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk requested a review from dav-is May 24, 2021 16:50
@ijjk
Copy link
Member Author

ijjk commented May 24, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/before-files Change
buildDuration 15s 14.9s -150ms
buildDurationCached 4.1s 3.7s -417ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +199 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/before-files Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.547 2.453 -0.09
/ avg req/sec 981.5 1019.01 +37.51
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.534 1.475 -0.06
/error-in-render avg req/sec 1629.31 1695.39 +66.08
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/before-files Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 994 B 994 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/before-files Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/before-files Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.54 kB 8.54 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/before-files Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/before-files Change
index.html gzip 561 B 561 B ✓
link.html gzip 570 B 570 B ✓
withRouter.html gzip 557 B 557 B ✓
Overall change 1.69 kB 1.69 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/before-files Change
buildDuration 15.4s 15.3s -149ms
buildDurationCached 4.7s 4.7s -1ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +199 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/before-files Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 994 B 994 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/before-files Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/before-files Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.54 kB 8.54 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/before-files Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary ijjk/next.js update/before-files Change
_error.js 16.9 kB 16.9 kB ✓
404.html 2.42 kB 2.42 kB ✓
500.html 2.41 kB 2.41 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.61 kB 1.61 kB ✓
css.html 1.79 kB 1.79 kB ✓
hooks.html 1.67 kB 1.67 kB ✓
index.js 17.2 kB 17.2 kB ✓
link.js 17.4 kB 17.4 kB -2 B
routerDirect.js 17.4 kB 17.4 kB ✓
withRouter.js 17.4 kB 17.4 kB ✓
Overall change 107 kB 107 kB -2 B
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/before-files Change
buildDuration 12.1s 12.2s ⚠️ +176ms
buildDurationCached 5.1s 5s -29ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +199 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/before-files Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.406 2.431 ⚠️ +0.02
/ avg req/sec 1039.23 1028.55 ⚠️ -10.68
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.232 1.243 ⚠️ +0.01
/error-in-render avg req/sec 2028.59 2010.74 ⚠️ -17.85
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/before-files Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.26 kB 7.26 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/before-files Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/before-files Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.74 kB 3.74 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.38 kB 9.38 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/before-files Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/before-files Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 2d5d5d1

@kodiakhq kodiakhq bot merged commit 38fa5ca into vercel:canary May 24, 2021
@sync-by-unito sync-by-unito bot mentioned this pull request May 26, 2021
Closed
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
@ijjk
Update beforeFiles rewrites to continue (vercel#25418)
25ec679 
This updates beforeFiles rewrites to continue instead of matching a public file/page immediately after a match, this allows all beforeFiles routes to be checked before matching the filesystem.

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.

## Documentation / Examples

- [ ] Make sure the linting passes
This was referenced Jul 29, 2021
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 19, 2021
Open
This was referenced Jan 12, 2022
Open
Open
Open
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@dav-is dav-is dav-is approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ijjk @timneutkens @dav-is