Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated fauna fql v10 #56185

Merged
merged 23 commits into from
Oct 11, 2023
Merged

updated fauna fql v10 #56185

merged 23 commits into from
Oct 11, 2023

Conversation

Shadid12
Copy link
Contributor

@Shadid12 Shadid12 commented Sep 28, 2023 •
edited
Loading

Maintenance

This PR removes legacy Fauna GraphQL endpoint and adds new Fauna FQL 10 queries to the example application.

@Shadid12 Shadid12 requested review from a team as code owners September 28, 2023 20:46
@Shadid12 Shadid12 requested review from manovotny and steven-tey and removed request for a team September 28, 2023 20:46
@ijjk ijjk added the examples Issue/PR related to examples label Sep 28, 2023
leerob
leerob reviewed Sep 29, 2023
View reviewed changes
examples/with-fauna/package.json Outdated Show resolved Hide resolved
examples/with-fauna/pages/api/entries/index.js Outdated Show resolved Hide resolved
examples/with-fauna/pages/index.js Outdated Show resolved Hide resolved
leerob
leerob reviewed Sep 29, 2023
View reviewed changes
examples/with-fauna/app/guestbook-page.js Outdated Show resolved Hide resolved
examples/with-fauna/app/layout.js Outdated Show resolved Hide resolved
examples/with-fauna/app/layout.js Outdated Show resolved Hide resolved
examples/with-fauna/app/layout.js Outdated Show resolved Hide resolved
@Shadid12 Shadid12 requested a review from leerob October 2, 2023 18:43
leerob
leerob reviewed Oct 2, 2023
View reviewed changes
examples/with-fauna/actions/entry.js Outdated Show resolved Hide resolved
examples/with-fauna/app/api/entries/route.js Outdated Show resolved Hide resolved
examples/with-fauna/app/guestbook-page.js Outdated Show resolved Hide resolved
examples/with-fauna/app/layout.js Outdated Show resolved Hide resolved
examples/with-fauna/app/page.js Outdated Show resolved Hide resolved
examples/with-fauna/components/EntryForm.js Outdated Show resolved Hide resolved
examples/with-fauna/lib/fauna.js Outdated Show resolved Hide resolved
examples/with-fauna/lib/fauna.js Outdated Show resolved Hide resolved
@Shadid12 Shadid12 requested a review from leerob October 3, 2023 04:49
leerob
leerob previously approved these changes Oct 4, 2023
View reviewed changes
@ijjk
Copy link
Member

ijjk commented Oct 4, 2023 •
edited by leerob
Loading

Allow CI Workflow Run

  • approve CI run for commit: b98372e

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

leerob
leerob reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we ensure linting was ran as well?

examples/with-fauna/actions/entry.js Outdated Show resolved Hide resolved
@Shadid12 Shadid12 requested a review from leerob October 4, 2023 04:49
@leerob leerob merged commit 216d968 into vercel:canary Oct 11, 2023
24 of 29 checks passed
@ztanner ztanner mentioned this pull request Oct 11, 2023
Merged
kodiakhq bot pushed a commit that referenced this pull request Oct 11, 2023
@ztanner
fix lint error from fauna example (#56719)
daa865f 
#56185 wasn't passing lint checks

[x-ref](https://github.com/vercel/next.js/actions/runs/6487087673/job/17616654281?pr=56718#step:28:196)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leerob leerob leerob approved these changes

@manovotny manovotny Awaiting requested review from manovotny manovotny was automatically assigned from vercel/devex

@steven-tey steven-tey Awaiting requested review from steven-tey steven-tey was automatically assigned from vercel/devex

Assignees
No one assigned
Labels
examples Issue/PR related to examples locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shadid12 @ijjk @leerob