Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build traces case #56817

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Fix build traces case #56817

merged 5 commits into from
Oct 13, 2023

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 13, 2023

This ensures our readFile handling for tracing we previously had is maintained.

Test deployment with the provided reproduction can be seen here: https://react-pdf-repro-jeqgyhmek-vtest314-ijjk-testing.vercel.app/

Fixes: #56676

huozhi
huozhi previously approved these changes Oct 13, 2023
@ijjk
Copy link
Member Author

ijjk commented Oct 13, 2023

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/build-trace-case Change
buildDuration 9.8s 10.5s ⚠️ +605ms
buildDurationCached 5.8s 6.3s ⚠️ +440ms
nodeModulesSize 172 MB 172 MB ⚠️ +9.25 kB
nextStartRea..uration (ms) 525ms 514ms N/A
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/build-trace-case Change
199-HASH.js gzip 27.5 kB 27.5 kB N/A
3f784ff6-HASH.js gzip 50.9 kB 50.9 kB
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.3 kB 45.3 kB
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 32.9 kB 32.9 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 96.4 kB 96.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/build-trace-case Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/build-trace-case Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.57 kB 2.57 kB N/A
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.35 kB 4.35 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.64 kB 2.63 kB N/A
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.08 kB 1.08 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/build-trace-case Change
_buildManifest.js gzip 485 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/build-trace-case Change
index.html gzip 528 B 529 B N/A
link.html gzip 541 B 542 B N/A
withRouter.html gzip 523 B 523 B
Overall change 523 B 523 B
Edge SSR bundle Size
vercel/next.js canary ijjk/next.js fix/build-trace-case Change
edge-ssr.js gzip 93.8 kB 93.8 kB
page.js gzip 152 kB 152 kB N/A
Overall change 93.8 kB 93.8 kB
Middleware size
vercel/next.js canary ijjk/next.js fix/build-trace-case Change
middleware-b..fest.js gzip 624 B 623 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 22.9 kB 22.9 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Commit: afeed1e

@ijjk ijjk marked this pull request as draft October 13, 2023 22:57
@ijjk ijjk marked this pull request as ready for review October 13, 2023 23:22
@ijjk ijjk merged commit d390c3d into vercel:canary Oct 13, 2023
57 of 58 checks passed
@ijjk ijjk deleted the fix/build-trace-case branch October 13, 2023 23:47
@github-actions github-actions bot added the locked label Nov 2, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vercel deployment stopped working after update from 13.5.3 to 13.5.4
3 participants