Skip to content

Commit

Permalink
Fixed an error when disposing a tech using manual timeupdates. closes #…
Browse files Browse the repository at this point in the history
  • Loading branch information
Matt Osborn authored and heff committed Jun 26, 2014
1 parent b66ef80 commit fe6946d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ CHANGELOG
* Fixed an IE11 issue where clicking on the video wouldn't show the controls ([view](https://github.com/videojs/video.js/pull/1291))
* Added a composer.json for PHP packages ([view](https://github.com/videojs/video.js/pull/1241))
* Exposed the vertical option for slider controls ([view](https://github.com/videojs/video.js/pull/1303))
* Fixed an error when disposing a tech using manual timeupdates ([view](https://github.com/videojs/video.js/pull/1312))

--------------------

Expand Down
3 changes: 2 additions & 1 deletion src/js/player.js
Original file line number Diff line number Diff line change
Expand Up @@ -290,13 +290,14 @@ vjs.Player.prototype.loadTech = function(techName, source){

vjs.Player.prototype.unloadTech = function(){
this.isReady_ = false;
this.tech.dispose();

// Turn off any manual progress or timeupdate tracking
if (this.manualProgress) { this.manualProgressOff(); }

if (this.manualTimeUpdates) { this.manualTimeUpdatesOff(); }

this.tech.dispose();

this.tech = false;
};

Expand Down

0 comments on commit fe6946d

Please sign in to comment.