src method failed between frames

[shmulik]

I am creating my playlist in the main window.
Each playlist have an array of sources.
The videojs player is running in an Iframe.
Each time an Item on the playlist is clicked, I am changing the src of the player using the src method, passing it the sources array.
But, since the code in "vjs.Player.prototype.src" function use "if (source instanceof Array)", and since the array of sources was created in another frame, the result of instanceof is false, and the sources not updated.
You should instead, use "Array.isArray(source)" to do the test for array.
Read more about "instanceof and multiple context (e.g. frames or windows)" here:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/instanceof

[mmcc]

I don't believe Array.isArray is supported in IE8, so it's not quite as easy as just using that instead. Do you have a reduced test case for this example somewhere?

[gkatsev]

We should be able to do a similar shim to how we're doing Object.create,

vjs.obj.isArray = Array.isArray || function(arr) {
  return Object.prototype.toString.call(arr) === "[object Array]";
};

[heff]

Yeah, that sounds good to me. @shmulik, do you want to make a pull request for this?

[shmulik]

Thanks all.
@heff , I've just created my first pull request:-)
Hope I did it correctly.
#1218

[heff]

The PR's looking good so far. Thanks!