flash.canPlaySource always false when codecs are listed in type field

[raycohen]

"video/flv": "FLV",
"video/x-flv": "FLV",
"video/mp4": "MP4",
"video/m4v": "MP4"

 if (srcObj.type in _V_.flash.prototype.support.formats) { return "maybe"; }

a valid type field may include more than just the mimetype:

http://diveintohtml5.info/video.html

  <source src="pr6.mp4"  type='video/mp4; codecs="avc1.42E01E, mp4a.40.2"'>

Would you accept a patch to fix this? Any thoughts on handling codecs in the type field?

[heff]

This should and will be fixed, however browsers don't actually parse the codec info. They'll return 'probably' if you include a codec, but from testing it's clear they don't actually look at what the codec is. So it's not currently going to add any benefit.

On Jan 12, 2012, at 1:38 PM, raycohen wrote:

"video/flv": "FLV",
"video/x-flv": "FLV",
"video/mp4": "MP4",
"video/m4v": "MP4"

if (srcObj.type in _V_.flash.prototype.support.formats) { return "maybe"; }

a valid type field may include more than just the mimetype:

http://diveintohtml5.info/video.html

 <source src="pr6.mp4"  type='video/mp4; codecs="avc1.42E01E, mp4a.40.2"'>

Would you accept a patch to fix this? Any thoughts on handling codecs in the type field?

---

Reply to this email directly or view it on GitHub:
#124

[jorrit]

I ran into this as well, my fix is:

_V_.flash.canPlaySource = function(srcObj){
  var filetype = srcObj.type;
  var semicolonPos = filetype.indexOf(';');

  if (semicolonPos != -1) {
    filetype = filetype.substring(0, semicolonPos);
  }

  if (filetype in _V_.flash.prototype.support.formats) { return "maybe"; }
};

[heff]

This was fixed in #805