Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to 'handleClick' listener naming over 'onClick' #1761

Closed
heff opened this issue Dec 19, 2014 · 2 comments
Closed

Switch to 'handleClick' listener naming over 'onClick' #1761

heff opened this issue Dec 19, 2014 · 2 comments
Labels
confirmed enhancement
Milestone
v5.0.0

Comments

@heff
Copy link
Member

heff commented Dec 19, 2014

At the moment, most components use the 'on[Event]' naming structure for private-ish event handler/listener functions. This could be confusing with the element attributes like onclick that let you add a listener without using addEventListener. We should switch to handle[Event] for the naming, unless anyone has a better suggestion.

This may or may not be a breaking change, so we should assume it is and release with 5.0.
@heff heff added this to the v5.0.0 milestone Dec 19, 2014
@mmcc mmcc added the confirmed label Jan 12, 2015
@heff heff mentioned this issue Apr 27, 2015
Closed
@bc-bbay
Copy link
Contributor

bc-bbay commented Apr 28, 2015

On it

bc-bbay added a commit to bc-bbay/video.js that referenced this issue Apr 28, 2015
@bc-bbay
onEvent > handleEvent
26b5fcb 
For issue videojs#1761
bc-bbay added a commit to bc-bbay/video.js that referenced this issue Apr 28, 2015
@bc-bbay
onEvent > handleEvent
6762886 
For issue videojs#1761
bc-bbay added a commit to bc-bbay/video.js that referenced this issue Apr 29, 2015
@bc-bbay
Refactor event handler names - onEvent -> handleEvent
bfe0464 
For videojs#1761
bc-bbay added a commit to bc-bbay/video.js that referenced this issue Apr 29, 2015
@bc-bbay
Refactor event handler names - onEvent -> handleEvent
e0a44a1 
For issue videojs#1761
@bc-bbay bc-bbay mentioned this issue Apr 29, 2015
Closed
@gkatsev
Copy link
Member

gkatsev commented May 1, 2015

Closed via #2093

@gkatsev gkatsev closed this as completed May 1, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
confirmed enhancement
Projects
None yet
Milestone
v5.0.0
Development

No branches or pull requests
4 participants
@heff @gkatsev @mmcc @bc-bbay