Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No tracks in Safari #1904

Closed
ksheurs opened this issue Feb 27, 2015 · 14 comments
Closed

No tracks in Safari #1904

ksheurs opened this issue Feb 27, 2015 · 14 comments
Labels
Milestone

Comments

@ksheurs
Copy link

ksheurs commented Feb 27, 2015

I am trying to upgrade to 4.12.2 (from 4.10.2) and finding subtitles are not working in Safari. Below are the two issues I am seeing:

On Safari desktop (v 6.0.5) there are no specific JavaScript errors, they just seem to silently not load. I am able to reproduce on www.videojs.com.

On Safari iOS they properly show in the native menu (http://cl.ly/image/0M180Y0t2Y3n), but selecting them does nothing. The only way I've been able to get subtitles working on iOS is to not initialize VideoJS and rely on native video + crossorigin="anonymous" on the video tag.

@gkatsev
Copy link
Member

gkatsev commented Feb 27, 2015

Hm... safari 6 I think has some issues with running vtt files natively. You also need to make sure that captions are enabled at the OS-level.
The crossorigin issue is something that we need to fix but yes, that is the workaround.

@ksheurs
Copy link
Author

ksheurs commented Feb 27, 2015

Any idea why subtitles would be working in Safari for VideoJS version 4.10.2?

@gkatsev
Copy link
Member

gkatsev commented Feb 27, 2015

We changed the way we're doing captions in 4.12. Unfortunately, we don't have a safari 6 desktop device to test with.

@heff heff added the bug label Feb 27, 2015
@heff
Copy link
Member

heff commented Feb 28, 2015

I can confirm that captions do not work in iOS on videojs.com. Shouldn't that work now?

@gkatsev
Copy link
Member

gkatsev commented Mar 9, 2015

It fell through the crack. Opened a new issue for the work needed to be done: #1941. The workaround is to add the attribute yourself.

@gkatsev
Copy link
Member

gkatsev commented Mar 9, 2015

This is because #1888 hasn't been implemented.

@gkatsev gkatsev added this to the Captions milestone Mar 9, 2015
@EZWrighter
Copy link

Wanted to add a note on this in Safari, I got captions working, but they display under the control bar by default. Which normally wouldn't be an issue if the controlbar disappears on mouse out, but in my case I needed to have the controlbar present all the time.

@heff
Copy link
Member

heff commented Apr 21, 2015

Could we style the shadow dom and make the captions move
up when the controls are showing?

On Tue, Apr 21, 2015 at 12:07 PM, Eric Zimmerman notifications@github.com
wrote:

Wanted to add a note on this in Safari, I got captions working, but they
display under the control bar by default. Which normally wouldn't be an
issue if the controlbar disappears on mouse out, but in my case I needed to
have the controlbar present all the time.


Reply to this email directly or view it on GitHub
#1904 (comment).

@EZWrighter
Copy link

Thanks for the idea Heff, but I don't think that will work on newer safari. Which is the place it is having problems. Tested safari 5 and the captions display in the right place. Safari 6 they display under the control bar. I know Safari removed a lot of the shadow dom functionality in newer releases.

@EZWrighter
Copy link

Ok...I tested Safari 6 and got the captions above controls with this css:

video::-webkit-media-text-track-container { bottom: 1.5em; }

makes it look a little higher in chrome on my machine, but an ok compromise.

Still need to check how this looks in Safari 5 though. I will update after testing.

@heff
Copy link
Member

heff commented Apr 21, 2015

I know Safari removed a lot of the shadow dom functionality in newer releases

Wow, lame.

@EZWrighter
Copy link

A quick update on this in Safari 5,6,8...the shadow dom CSS hack works fine to make captions display in an acceptable location in those browsers. I do only use this CSS in Safari.

@heff
Copy link
Member

heff commented Apr 24, 2015

Nice. Want to make a PR to add that?

On Fri, Apr 24, 2015 at 2:20 PM, Eric Zimmerman notifications@github.com
wrote:

A quick update on this in Safari 5,6,8...the shadow dom CSS hack works
fine to make captions display in an acceptable location in those browsers.
I do only use this CSS in Safari.


Reply to this email directly or view it on GitHub
#1904 (comment).

@gkatsev
Copy link
Member

gkatsev commented Jul 15, 2015

So, we've decided that the best course of action is for users to either load in the text tracks from the same domain as the page its hosted on or to also enable CORS for the video files themselves and then add the crossorigin attribute themselves. See #1888 for the details around it.
Going to close this now since there isn't anything we're going to do directly for this issue and there's #1888.
The safari/chrome shadow dom thing should go into another issue.

@gkatsev gkatsev closed this as completed Jul 15, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants