-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No tracks in Safari #1904
Comments
Hm... safari 6 I think has some issues with running vtt files natively. You also need to make sure that captions are enabled at the OS-level. |
Any idea why subtitles would be working in Safari for VideoJS version 4.10.2? |
We changed the way we're doing captions in 4.12. Unfortunately, we don't have a safari 6 desktop device to test with. |
I can confirm that captions do not work in iOS on videojs.com. Shouldn't that work now? |
It fell through the crack. Opened a new issue for the work needed to be done: #1941. The workaround is to add the attribute yourself. |
This is because #1888 hasn't been implemented. |
Wanted to add a note on this in Safari, I got captions working, but they display under the control bar by default. Which normally wouldn't be an issue if the controlbar disappears on mouse out, but in my case I needed to have the controlbar present all the time. |
Could we style the shadow dom and make the captions move On Tue, Apr 21, 2015 at 12:07 PM, Eric Zimmerman notifications@github.com
|
Thanks for the idea Heff, but I don't think that will work on newer safari. Which is the place it is having problems. Tested safari 5 and the captions display in the right place. Safari 6 they display under the control bar. I know Safari removed a lot of the shadow dom functionality in newer releases. |
Ok...I tested Safari 6 and got the captions above controls with this css:
makes it look a little higher in chrome on my machine, but an ok compromise. Still need to check how this looks in Safari 5 though. I will update after testing. |
Wow, lame. |
A quick update on this in Safari 5,6,8...the shadow dom CSS hack works fine to make captions display in an acceptable location in those browsers. I do only use this CSS in Safari. |
Nice. Want to make a PR to add that? On Fri, Apr 24, 2015 at 2:20 PM, Eric Zimmerman notifications@github.com
|
So, we've decided that the best course of action is for users to either load in the text tracks from the same domain as the page its hosted on or to also enable CORS for the video files themselves and then add the |
I am trying to upgrade to 4.12.2 (from 4.10.2) and finding subtitles are not working in Safari. Below are the two issues I am seeing:
On Safari desktop (v 6.0.5) there are no specific JavaScript errors, they just seem to silently not load. I am able to reproduce on www.videojs.com.
On Safari iOS they properly show in the native menu (http://cl.ly/image/0M180Y0t2Y3n), but selecting them does nothing. The only way I've been able to get subtitles working on iOS is to not initialize VideoJS and rely on native video +
crossorigin="anonymous"
on the video tag.The text was updated successfully, but these errors were encountered: