Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bower updates #1123

Closed
wants to merge 4 commits into from
Closed

Bower updates #1123

wants to merge 4 commits into from

Conversation

jonkoops
Copy link

Updated version number in bower.json and removed deprecated component.json

@gkatsev
Copy link
Member

gkatsev commented Mar 31, 2014

I believe the component.json that is currently in the repo is to support component(1) rather than to support bower. See #1032.

@jonkoops
Copy link
Author

@gkatsev Roger that, reverted the commit and changed the version number in component.json to latest as well.

@gkatsev
Copy link
Member

gkatsev commented Mar 31, 2014

Cool, thanks!.

@heff we need to update the release process to also change bower.json and component.json.

@jonkoops
Copy link
Author

@gkatsev Yeah, that'd be great. Is video.js using semantic versioning by the way?

@gkatsev
Copy link
Member

gkatsev commented Mar 31, 2014

@jonkoops yes. At least, it tries.

@heff
Copy link
Member

heff commented Mar 31, 2014

@gkatsev, yeah we do. Feel like making a pull request for that? For videojs.com I used grunt-version, and that worked well. It could replace grunt-bump.

@jonkoops
Copy link
Author

@heff Seems like grunt-bump supports multiple package formats as well https://github.com/vojtajina/grunt-bump#files.

@heff
Copy link
Member

heff commented Mar 31, 2014

Got it, yeah that'd work. I was thinking it was deprecated, but that's grunt-tagrelease.

On Mar 31, 2014, at 2:05 PM, Jon Koops notifications@github.com wrote:

@heff Seems like grunt-bump supports multiple package formats as well https://github.com/vojtajina/grunt-bump#files.


Reply to this email directly or view it on GitHub.

@jonkoops
Copy link
Author

jonkoops commented Apr 3, 2014

@gkatsev @heff Should I update the release script to account for this? Cause that would make this pull request obsolete.

@gkatsev
Copy link
Member

gkatsev commented Apr 3, 2014

@jonkoops If you can give that a go, that would be awesome.

@heff
Copy link
Member

heff commented Apr 3, 2014

Sorry, I've been delayed on pulling this in because I need to do a little git magic to get this pulled into the stable branch instead of master. If you do make any updates, could you base them on stable and make a new PR against stable?

@gkatsev
Copy link
Member

gkatsev commented Apr 3, 2014

I was thinking that we get the release process updated and we could just do a patch release. Or something.

@heff
Copy link
Member

heff commented Apr 3, 2014

Yeah, exactly. A patch needs to be based on stable, otherwise it'd pull in any new features from master.

@jonkoops
Copy link
Author

jonkoops commented Apr 3, 2014

@heff Looks like grunt-tagrelease is being deprecated in favour of grunt-release. I'll try to include it in my pull request.

@jonkoops
Copy link
Author

jonkoops commented Apr 3, 2014

The NPM dependencies are generally very out-of-date:

"calcdeps" can be updated from ~0.1.7 to ~0.2.0 (Installed: 0.1.7, Latest: 0.2.0)
"contribflow" can be updated from ~0.2.0 to ~0.3.7 (Installed: 0.2.0, Latest: 0.3.7)
"github" can be updated from ~0.1.14 to ~0.1.15 (Installed: 0.1.15, Latest: 0.1.15)
"grunt-banner" can be updated from ~0.2.0 to ~0.2.2 (Installed: 0.2.2, Latest: 0.2.2)
"grunt-cli" can be updated from ~0.1.0 to ~0.1.13 (Installed: 0.1.13, Latest: 0.1.13)
"grunt-contrib-clean" can be updated from ~0.4.0a to ~0.5.0 (Installed: 0.4.1, Latest: 0.5.0)
"grunt-contrib-copy" can be updated from ~0.3.2 to ~0.5.0 (Installed: 0.3.2, Latest: 0.5.0)
"grunt-contrib-cssmin" can be updated from ~0.6.0 to ~0.9.0 (Installed: 0.6.2, Latest: 0.9.0)
"grunt-contrib-jshint" can be updated from ~0.4.3 to ~0.10.0 (Installed: 0.4.3, Latest: 0.10.0)
"grunt-contrib-less" can be updated from ~0.6.4 to ~0.11.0 (Installed: 0.6.5, Latest: 0.11.0)
"grunt-contrib-qunit" can be updated from ~0.2.1 to ~0.4.0 (Installed: 0.2.2, Latest: 0.4.0)
"grunt-contrib-watch" can be updated from ~0.1.4 to ~0.6.1 (Installed: 0.1.4, Latest: 0.6.1)
"grunt-karma" can be updated from ~0.6.2 to ~0.8.2 (Installed: 0.6.2, Latest: 0.8.2)
"grunt-s3" can be updated from ~0.2.0-alpha to ~0.2.0-alpha (Installed: 0.2.0-alpha.3, Latest: 0.2.0-alpha.3)
"grunt-zip" can be updated from 0.10.2 to 0.13.0 (Installed: 0.10.2, Latest: 0.13.0)
"karma" can be updated from ~0.10.0 to ~0.12.3 (Installed: 0.10.10, Latest: 0.12.3)
"karma-chrome-launcher" can be updated from ~0.1.2 to ~0.1.3 (Installed: 0.1.3, Latest: 0.1.3)
"karma-ie-launcher" can be updated from ~0.1.1 to ~0.1.4 (Installed: 0.1.4, Latest: 0.1.4)
"karma-phantomjs-launcher" can be updated from ~0.1.1 to ~0.1.3 (Installed: 0.1.3, Latest: 0.1.3)
"mocha" can be updated from ~1.8.1 to ~1.18.2 (Installed: 1.8.2, Latest: 1.18.2)
"qunitjs" can be updated from ~1.12.0 to ~1.14.0 (Installed: 1.12.0, Latest: 1.14.0)
"semver" can be updated from ~1.1.4 to ~2.2.1 (Installed: 1.1.4, Latest: 2.2.1)
"uglify-js" can be updated from ~2.3.6 to ~2.4.13 (Installed: 2.3.6, Latest: 2.4.13)

@heff
Copy link
Member

heff commented Apr 3, 2014

Yeah, if you see any that are no longer used feel free to remove them. I wouldn't get into upgrading all of them. That could make this much more complicated to deal with. I'll try upgrading some of them when I do the next release.

@gkatsev
Copy link
Member

gkatsev commented Apr 3, 2014

Yeah, exactly. A patch needs to be based on stable, otherwise it'd pull in any new features from master.

Oh, I see.

@gkatsev
Copy link
Member

gkatsev commented Apr 3, 2014

Yeah, updating deps and devDeps should be a separate task.

@heff heff added enhancement and removed bug labels Apr 4, 2014
@jonkoops
Copy link
Author

jonkoops commented Apr 7, 2014

I'll go a ahead and close this pull request, I'll try to submit a patch for the release script soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants