Added cog icon #1211
Closed
Added cog icon #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since it's totally not obvious right now, I wanted to point out the CDN fonts are actually versioned separately. So what I'll end up doing here is pulling this in, uploading the new fonts to vjs.zencdn.net/f/3/ and then updating the grunt task to point to the new version. It could be worth breaking out the font into a separate repo at some point and making it a dependency of this one. Similar to what we've done with the swf. |
|
Also, currently there's no automated process for uploading the fonts to s3 and updating permissions or content-type and cache-control headers, so it's a bit of a copy/paste pain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a cog icon and removed unused PNG files.