Issue #1309: fix adding/removing event handlers in IE8

[NielsDoucet]

Small fix for IE8 compatibility regarding event handlers.

P.S. I tried using the contrib flow, but it doesn't appear to finish the flow properly (after providing username, password, title and description, it just returns undefined. It might be because I have some 'funny' characters in my password, but I'm not sure).

[NielsDoucet]

Well, cleanup before merging.. that wasn't very handy of me :)

[heff]

We get errors when videojs is trying to attach events to certain elements in IE8.
The checks for document.removeEventListener and document.addEventListener inside events.js do not guarantee the existence of elem.removeEventListener or elem.addEventListener.
The checks should probably be made on the elem object instead, to make absolutely sure.
I will open a pull-request for this as it is a trivial fix.

That's interesting, which elements? addEventListener specifically shouldn't exist at all in IE8, are you finding that it does in some cases? We probably should be checking the element either way, but I'd like to understand what's happening here a little better.

Also, sorry about contrib flow. Working on an update there.

[NielsDoucet]

I'm not too sure about the specifics, as it was a colleague that found the issue, but I'm pretty sure it's due to a buggy shim or polyfill interacting negatively here.

[heff]

Ok cool, thanks. lgtm

[heff]

Thanks!

[NielsDoucet]

Any idea when this fix can make it into a release?
We're going live with a project at the start of September and were hoping to be able to use the CDN.

[gkatsev]

Given that it has been merged, it should make it to the next release. Hopefully, this release lands really soon and most likely with plenty of time for you to test.

[NielsDoucet]

Sounds good, thanks 👍

[mmcc]

Just an FYI (I'm sure there will be a more formal announcement), but we're going to start trying to follow a deploy schedule. I think the plan right now is to deploy every Tuesday (if there's something to deploy), so this should go out tomorrow.