Publish videojs.Player.prototype.selectSource function. #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ojs.Player.prototype.selectSource function. This allows developers to provide their own algorithms for selecting which source a Player should use.
|
looks good to me, thanks! |
heff
added a commit
that referenced
this pull request
Aug 20, 2014
|
Merged this in and it's in the 4.7.3 release. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed offline with @heff and in Issue #1384, allowing developers to patch, replace, and/or experiment with source selection algorithms is a desirable feature. Such capability is currently blocked because the selectSource function's name is obfuscated by the closure compiler. This change adds the selectSource function to the set of functions that are exported by VideoJS, preventing it from name obfuscation.